Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]

### Fixes
- ESC key pressed on a trigger element should propagate event if `Popup` is closed @sophieH29 ([#1373](https://github.com/stardust-ui/react/pull/1373))

### Features
- Add keyboard navigation and screen reader support for `Accordion` @silviuavram ([#1322](https://github.com/stardust-ui/react/pull/1322))
- Add `expanded` prop to `Accordion` @silviuavram ([#1322](https://github.com/stardust-ui/react/pull/1322))
Expand Down
3 changes: 1 addition & 2 deletions packages/react/src/components/Popup/Popup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,9 @@ export default class Popup extends AutoControlledComponent<PopupProps, PopupStat
protected actionHandlers: AccessibilityActionHandlers = {
closeAndFocusTrigger: e => {
this.close(e, () => _.invoke(this.triggerFocusableDomElement, 'focus'))
e.stopPropagation()
},
close: e => {
this.close(e)
e.stopPropagation()
},
toggle: e => {
e.preventDefault()
Expand Down Expand Up @@ -552,6 +550,7 @@ export default class Popup extends AutoControlledComponent<PopupProps, PopupStat
if (this.state.open) {
this.trySetOpen(false, e)
onClose && onClose()
e.stopPropagation()
}
}

Expand Down