This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(fela): plugin order, invokeKeyframes #1741
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`CSS fallback values are rendered 1`] = ` | ||
| ".a { | ||
| color: red; | ||
| color: blue; | ||
| } | ||
|
|
||
|
|
||
| <div className=ui-box a />; | ||
| " | ||
| `; | ||
|
|
||
| exports[`array returned by keyframe results in CSS fallback values 1`] = ` | ||
| "@-webkit-keyframes k1 { | ||
| 0% { | ||
| color: blue; | ||
| color: red; | ||
| color: yellow; | ||
| } | ||
| 100% { | ||
| color: blue; | ||
| color: red; | ||
| color: yellow; | ||
| } | ||
| } | ||
| @-moz-keyframes k1 { | ||
| 0% { | ||
| color: blue; | ||
| color: red; | ||
| color: yellow; | ||
| } | ||
| 100% { | ||
| color: blue; | ||
| color: red; | ||
| color: yellow; | ||
| } | ||
| } | ||
| @keyframes k1 { | ||
| 0% { | ||
| color: blue; | ||
| color: red; | ||
| color: yellow; | ||
| } | ||
| 100% { | ||
| color: blue; | ||
| color: red; | ||
| color: yellow; | ||
| } | ||
| } | ||
| .a { | ||
| animation-name: k1; | ||
| } | ||
|
|
||
|
|
||
| <div className=ui-provider__box dir=ltr> | ||
| <div className=ui-box a /> | ||
| </div>; | ||
| " | ||
| `; | ||
|
|
||
| exports[`basic styles are rendered 1`] = ` | ||
| ".a { | ||
| color: red; | ||
| } | ||
|
|
||
|
|
||
| <div className=ui-box a />; | ||
| " | ||
| `; | ||
|
|
||
| exports[`keyframe colors are rendered 1`] = ` | ||
| "@-webkit-keyframes k1 { | ||
| from { | ||
| color: red; | ||
| } | ||
| to { | ||
| color: blue; | ||
| } | ||
| } | ||
| @-moz-keyframes k1 { | ||
| from { | ||
| color: red; | ||
| } | ||
| to { | ||
| color: blue; | ||
| } | ||
| } | ||
| @keyframes k1 { | ||
| from { | ||
| color: red; | ||
| } | ||
| to { | ||
| color: blue; | ||
| } | ||
| } | ||
| .a { | ||
| animation-name: k1; | ||
| } | ||
| .b { | ||
| animation-duration: 5s; | ||
| } | ||
|
|
||
|
|
||
| <div className=ui-provider__box dir=ltr> | ||
| <div className=ui-box a b /> | ||
| </div>; | ||
| " | ||
| `; | ||
|
|
||
| exports[`marginLeft is rendered into marginRight due to RTL 1`] = ` | ||
| ".a { | ||
| margin-right: 10px; | ||
| } | ||
|
|
||
|
|
||
| <div className=ui-provider__box dir=rtl> | ||
| <span className=ui-text a dir=auto> | ||
| Hello | ||
| </span> | ||
| </div>; | ||
| " | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import * as React from 'react' | ||
| import { createSnapshot } from 'jest-react-fela' | ||
| import { EmptyThemeProvider } from 'test/utils' | ||
| import Box from 'src/components/Box/Box' | ||
| import Provider from 'src/components/Provider/Provider' | ||
| import Text from 'src/components/Text/Text' | ||
| import { felaRenderer } from 'src/lib' | ||
|
|
||
| test('basic styles are rendered', () => { | ||
| const snapshot = createSnapshot( | ||
| <EmptyThemeProvider> | ||
| <Box styles={{ color: 'red' }} /> | ||
lucivpav marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </EmptyThemeProvider>, | ||
| {}, | ||
| felaRenderer, | ||
| ) | ||
| expect(snapshot).toMatchSnapshot() | ||
| }) | ||
|
|
||
| test('CSS fallback values are rendered', () => { | ||
| const snapshot = createSnapshot( | ||
| <EmptyThemeProvider> | ||
| <Box styles={{ color: ['red', 'blue'] }} /> | ||
| </EmptyThemeProvider>, | ||
| {}, | ||
| felaRenderer, | ||
| ) | ||
| expect(snapshot).toMatchSnapshot() | ||
| }) | ||
|
|
||
| test('keyframe colors are rendered', () => { | ||
| const spinner = { | ||
| keyframe: ({ fromColor, toColor }) => ({ | ||
| from: { | ||
| color: fromColor, | ||
| }, | ||
| to: { | ||
| color: toColor, | ||
| }, | ||
| }), | ||
| keyframeParams: { | ||
| fromColor: 'red', | ||
| toColor: 'blue', | ||
| }, | ||
| duration: '5s', | ||
| } | ||
|
|
||
| const snapshot = createSnapshot( | ||
| <Provider theme={{ animations: { spinner } }}> | ||
| <Box animation="spinner" /> | ||
| </Provider>, | ||
| {}, | ||
| felaRenderer, | ||
| ) | ||
| expect(snapshot).toMatchSnapshot() | ||
| }) | ||
|
|
||
| test('array returned by keyframe results in CSS fallback values', () => { | ||
| const steps = ['0%', '100%'] | ||
|
|
||
| const spinner = { | ||
| keyframe: ({ steps }) => { | ||
| const obj = {} | ||
| steps.forEach((step: string, index) => { | ||
| ;(obj as any)[step] = { color: ['blue', 'red', 'yellow'] } | ||
| }) | ||
| return obj | ||
| }, | ||
| keyframeParams: { steps }, | ||
| } | ||
|
|
||
| const snapshot = createSnapshot( | ||
| <Provider theme={{ animations: { spinner } }}> | ||
| <Box animation="spinner" /> | ||
| </Provider>, | ||
| {}, | ||
| felaRenderer, | ||
| ) | ||
| expect(snapshot).toMatchSnapshot() | ||
| }) | ||
|
|
||
| test('marginLeft is rendered into marginRight due to RTL', () => { | ||
| const snapshot = createSnapshot( | ||
| <Provider rtl={true}> | ||
| <Text content="Hello" styles={{ marginLeft: '10px' }} /> | ||
| </Provider>, | ||
| {}, | ||
| felaRenderer, | ||
| ) | ||
| expect(snapshot).toMatchSnapshot() | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should wait for #1743 to be merged first and remove this change here.
@layershifter Do you agree?