This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusTrapZone): Do not force focus inside focus trap zone on outside focus#1930
Merged
jurokapsiar merged 3 commits intomasterfrom Sep 13, 2019
Merged
Conversation
Collaborator
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
========================================
Coverage ? 70.5%
========================================
Files ? 884
Lines ? 7794
Branches ? 2254
========================================
Hits ? 5495
Misses ? 2289
Partials ? 10
Continue to review full report at Codecov.
|
Contributor
|
Keeping some context for the future here: This behavior changed between different versions of (Fabric) FocusTrapZone. So reverting to the previous behavior as it breaks some of the scenarios in Stardust. To use the default Fabric behavior, we can still use We should probably use false for popup by default and true for dialog (?) but it requires some testing. |
layershifter
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popup in Menu scenario was broken due to a recent focus trap zone update to the Fabric latest version.
For now, switching it back to Stardust default behavior, we will investigate later how to align.
Repro: https://codesandbox.io/s/stardust-ui-example-yjnqv