Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(FocusTrapZone): Do not force focus inside focus trap zone on outside focus #1930

Merged
jurokapsiar merged 3 commits into from
Sep 13, 2019
Merged

fix(FocusTrapZone): Do not force focus inside focus trap zone on outside focus #1930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be586e2
fix(FocusTrapZone): Do not force focus inside focus trap zone on outs…
Sep 13, 2019
23d1f8c
changelog
Sep 13, 2019
b3ac9e1
Merge branch 'master' into fix/focus-trap-zone-on-outside-focus
Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react/src/lib/accessibility/FocusZone/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ This is a list of changes made to the Stardust copy of FocusTrapZone in comparis

### BREAKING CHANGES
- Allow using `firstFocusableSelector` for all type of selectors, not only class names @sophieH29 ([#1732](https://github.com/stardust-ui/react/pull/1732))
- Do not force focus inside focus trap zone on outside focus @sophieH29 ([#1930](https://github.com/stardust-ui/react/pull/1930))

### Fixes
- Do not focus trigger on outside click @sophieH29 ([#627](https://github.com/stardust-ui/react/pull/627))
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/lib/accessibility/FocusZone/FocusTrapZone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class FocusTrapZone extends React.Component<FocusTrapZoneProps, {
static defaultProps: FocusTrapZoneProps = {
as: 'div',
isClickableOutsideFocusTrap: true,
forceFocusInsideTrapOnOutsideFocus: true,
forceFocusInsideTrapOnOutsideFocus: false,
}

componentDidMount(): void {
Expand Down