Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

WIP: Custom scrollbar proto for dropdown#2008

Closed
jurokapsiar wants to merge 7 commits intomasterfrom
dropdown-custom-scroll
Closed

WIP: Custom scrollbar proto for dropdown#2008
jurokapsiar wants to merge 7 commits intomasterfrom
dropdown-custom-scroll

Conversation

@jurokapsiar
Copy link
Contributor

This PR adds Dropdown to the custom scrollbar prototypes.

TODO: border and shadow is not applied

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Oct 4, 2019

Fails
🚫 All of your entries in CHANGELOG.md should be in the **Unreleased** section!
Warnings
⚠️ New package.json added: packages/state/package.json. Make sure you have approval before merging!
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.

Changed dependencies in packages/code-sandbox/package.json

package before after
@stardust-ui/react ^0.39.0 ^0.40.1

Changed dependencies are detected.

Changed dependencies in packages/react-bindings/package.json

package before after
@stardust-ui/accessibility - ^0.40.0
@stardust-ui/state - ^0.40.0

Changed dependencies are detected.

Changed dependencies in packages/internal-tooling/package.json

package before after
@stardust-ui/eslint-plugin ^0.39.0 ^0.40.0

Changed dependencies are detected.

Changed dependencies in packages/react/package.json

package before after
@stardust-ui/accessibility ^0.39.0 ^0.40.0
@stardust-ui/react-bindings ^0.39.0 ^0.40.0
@stardust-ui/react-component-event-listener ^0.39.0 ^0.40.0
@stardust-ui/react-component-nesting-registry ^0.39.0 ^0.40.0
@stardust-ui/react-component-ref ^0.39.0 ^0.40.0
@stardust-ui/react-proptypes ^0.39.0 ^0.40.0
downshift ~3.2.10 3.2.14

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #2008 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2008      +/-   ##
==========================================
+ Coverage   77.01%   77.02%   +<.01%     
==========================================
  Files         158      158              
  Lines        5456     5458       +2     
  Branches     1594     1579      -15     
==========================================
+ Hits         4202     4204       +2     
  Misses       1241     1241              
  Partials       13       13
Impacted Files Coverage Δ
...ackages/react/src/components/Dropdown/Dropdown.tsx 87.84% <100%> (+0.03%) ⬆️
packages/react/src/components/List/List.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799e8d5...b6b55fe. Read the comment docs.

@jurokapsiar
Copy link
Contributor Author

wrong approach and wrong merge. closing the PR as there is a replacement: #2092

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants