This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(List+Dropdown): wrapper for custom scrollbar in list#2092
Merged
jurokapsiar merged 9 commits intomasterfrom Jan 15, 2020
Merged
feat(List+Dropdown): wrapper for custom scrollbar in list#2092jurokapsiar merged 9 commits intomasterfrom
jurokapsiar merged 9 commits intomasterfrom
Conversation
jurokapsiar
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
approved these changes
Nov 12, 2019
mnajdova
reviewed
Nov 13, 2019
mnajdova
reviewed
Nov 13, 2019
mnajdova
reviewed
Nov 13, 2019
jurokapsiar
requested review from
JasonGore,
dzearing,
ecraig12345,
jdhuntington and
kenotron
as code owners
Collaborator
Perf comparison
Generated by 🚫 dangerJS |
jurokapsiar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional prop/slot for container in list which allows the Dropdown to integrate with custom scrollbars.
Dropdown focuses its list after open. As some custom scrollbar libraries render itself twice, the focusing was broken (first rendered element was focused, then removed)
Instead, a wrapper between the list and list item is added, which can be used to inject the custom scrollbars.