This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): prevent unintentional content wrapping#2073
Closed
miroslavstastny wants to merge 4 commits intomasterfrom
Closed
fix(Popup): prevent unintentional content wrapping#2073miroslavstastny wants to merge 4 commits intomasterfrom
miroslavstastny wants to merge 4 commits intomasterfrom
Conversation
…ing on window resize
miroslavstastny
requested review from
dvdzkwsk,
layershifter,
levithomason and
mnajdova
as code owners
Collaborator
Generated by 🚫 dangerJS |
| borderRadius: v.borderRadius, | ||
| boxShadow: v.boxShadow, | ||
|
|
||
| width: 'fit-content', |
Member
There was a problem hiding this comment.
It seems that it will not work for IE:
Member
Author
There was a problem hiding this comment.
But this is just a workaround for #2067 which is a workaround for bug in Chrome 69.
@jurokapsiar - what if we do #2067 conditionally only in Chrome?
Contributor
There was a problem hiding this comment.
agree - in chrome and presumably in all chromium browsers (new edge)
Member
Author
There was a problem hiding this comment.
Both @levithomason and @dzearing are strongly against browser-specific code
Member
Author
|
|
jurokapsiar
approved these changes
Nov 19, 2019
Member
Author
|
Fixed better in #2187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent unintentional Popup content wrapping to fix re-positioning on window resize.
Fixes #2072