This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popper): improve positioning in multiple cases#2187
Merged
layershifter merged 8 commits intomasterfrom Dec 19, 2019
Merged
Conversation
layershifter
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
docs/update-examples
branch
from
0df1bae to
049ab2b
Compare
Collaborator
layershifter
changed the title
miroslavstastny
approved these changes
Dec 19, 2019
| }) | ||
|
|
||
| const originalUpdate = instance.update | ||
| instance.update = () => { |
Member
There was a problem hiding this comment.
Why the PR title says 'first render'? This fixes resizing after the first render.
layershifter
changed the title
|
😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2064.
Fixes #2072.
Case 1: jump on focus
The same as mui/material-ui#16740, when opening a
Popupwith an autofocus input inside it, should not cause the page to jump (scroll).Case 2: scrollbar sizing issues
See code comments for descriptions and linked issues.