This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Button): Add new color scheme tokens & update iconOnly button styles for Teams theme#2211
Merged
codepretty merged 7 commits intomasterfrom Jan 30, 2020
Merged
Conversation
codepretty
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
codepretty
changed the title
codepretty
changed the title
Collaborator
Perf comparison
Generated by 🚫 dangerJS |
added 2 commits
January 7, 2020 14:56
…over states and use the new backgroundHover2 token
mnajdova
approved these changes
Jan 14, 2020
Contributor
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
LGTM, make sure the screener differences are accepted
notandrew
approved these changes
Jan 17, 2020
added 2 commits
January 28, 2020 08:21
This was referenced Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
background5andbackgroundHover2default design token in Teams themesUpdated iconOnly buttons to use
backgroundHover2for the correct hover background in Teams high contrast themeBefore
After
Before
After
Example using the new background5 token for a background in all Teams themes
