Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(Attachment): fix an CSS-in-JS issue in styles#2302

Merged
layershifter merged 1 commit intomasterfrom
fix/attachment-styles
Jan 31, 2020
Merged

fix(Attachment): fix an CSS-in-JS issue in styles#2302
layershifter merged 1 commit intomasterfrom
fix/attachment-styles

Conversation

@layershifter
Copy link
Member

image

Fixes a small issue introduced in #2211, see 2689e7a#diff-a62ff2ea0b930e7985298be8a51cea7aR78.

FYI: @codepretty

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.58 0.41 1.41:1 2000 1168
🔧 Button.Fluent 1.25 0.17 7.35:1 1000 1246
🔧 Checkbox.Fluent 1.48 0.33 4.48:1 1000 1483
🔧 Dialog.Fluent 0.33 0.17 1.94:1 5000 1627
🔧 Dropdown.Fluent 3.56 0.38 9.37:1 1000 3564
🔧 Icon.Fluent 0.24 0.04 6:1 5000 1199
🔧 Image.Fluent 0.1 0.09 1.11:1 5000 501
🔧 Slider.Fluent 2.1 0.33 6.36:1 1000 2098
🦄 Text.Fluent 0.05 0.19 0.26:1 5000 256
🦄 Tooltip.Fluent 0.34 19.18 0.02:1 5000 1712

🔧 Needs work     🎯 On target     🦄 Amazing

Generated by 🚫 dangerJS

@layershifter layershifter merged commit 3a3f99c into master Jan 31, 2020
@layershifter layershifter deleted the fix/attachment-styles branch January 31, 2020 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🧰 fix Introduces fix for broken behavior. ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants