Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

docs: add glossary to specifications#4

Closed
levithomason wants to merge 4 commits intomasterfrom
spec/glossary
Closed

docs: add glossary to specifications#4
levithomason wants to merge 4 commits intomasterfrom
spec/glossary

Conversation

@levithomason
Copy link
Member

@levithomason levithomason commented Jul 20, 2018

@bmdalex
Copy link
Collaborator

bmdalex commented Jul 30, 2018

My proposal for spacing:

xSpacing=['none'|'before'|'after'|'both']
ySpacing=['none'|'before'|'after'|'both']

already implemented for Icon here #22

@mnajdova @levithomason

@mnajdova
Copy link
Contributor

For the components that can contain some removable icon, using the convention from SUI we can use the onRemove and removeIcon props. (implemented in the PR for the removable Label) #19

@levithomason
Copy link
Member Author

See #39 for xSpacing / fitted proposal and discussion.

@levithomason
Copy link
Member Author

This is now being handled in the documentation PRs. This information is being added to the doc site instead of as markdown. The props and descriptions are also going to be available in the doc site opposed to markdown.

@levithomason levithomason deleted the spec/glossary branch September 6, 2018 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants