fix(docs): fix conflict Fela and FontAwesome#951
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
| felaPluginFallbackValue(), | ||
| ...(options.isRtl ? [rtl()] : []), | ||
| ], | ||
| filterClassName, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Just as I see it here: you can now use the rtl plugin with a theme.direction property to trigger rtl transformation (check the plugin docs) that way you dont have to conditionally add the plugin
There was a problem hiding this comment.
Yep, seen these changes. Going to visit this place in a separate PR 👍
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
=========================================
- Coverage 80.51% 80.5% -0.01%
=========================================
Files 659 659
Lines 8447 8450 +3
Branches 1492 1429 -63
=========================================
+ Hits 6801 6803 +2
- Misses 1631 1632 +1
Partials 15 15
Continue to review full report at Codecov.
|
|
|
||
| // Blacklist contains a list of classNames that are used by FontAwesome | ||
| // https://fontawesome.com/how-to-use/on-the-web/referencing-icons/basic-use | ||
| const blacklistedClassNames = ['fa', 'fas', 'far', 'fal', 'fab'] |
There was a problem hiding this comment.
a bit concerned about these as they can change at any time in fontawesome and we have no control over that..
There was a problem hiding this comment.
agree - especially given that each theme might load CSS libraries with different set of class names that should be blacklisted. Would expect that this blacklisted information will be defined by theme, not (only) general Stardust logic - and, thus, would be extendable
…dust-ui/react into docs/fela-fa # Conflicts: # CHANGELOG.md
6 participants
Fixes #950.