This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): Fela and fontAwesome classes conflict#952
Closed
Conversation
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Member
|
What about #951? |
Collaborator
Author
|
@miroslavstastny haha, let's vote? 😆 |
Collaborator
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
=======================================
Coverage 80.51% 80.51%
=======================================
Files 659 659
Lines 8448 8448
Branches 1492 1428 -64
=======================================
Hits 6802 6802
Misses 1631 1631
Partials 15 15
Continue to review full report at Codecov.
|
Collaborator
Author
|
closing in favor of #951 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(docs): Fela and fontAwesome classes conflict
Fixes #950
Fix is proposed by @rofrischmann (creator of Fela) here
Downside:
The prefix is added to all class names:
EDIT:
Alternative to #951