For all gulp build:docs tasks that have a src->cache->dest, use cwd/base#12060
Merged
msft-github-bot merged 4 commits intomicrosoft:masterfrom Feb 25, 2020
Merged
For all gulp build:docs tasks that have a src->cache->dest, use cwd/base#12060msft-github-bot merged 4 commits intomicrosoft:masterfrom
msft-github-bot merged 4 commits intomicrosoft:masterfrom
Conversation
…chine doesn't get bogged down by random cached bits
ecraig12345
approved these changes
Feb 25, 2020
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4460bc39dcc5d6f4c7221aa84bed2311aa65ffe0 (build) |
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
All perf tests
|
Contributor
|
Hello @ecraig12345! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 29 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
@msft-github-bot merge this pr in 1 minute |
Contributor
|
Hello @ecraig12345! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Member
|
Great! I'm hoping this fixes the regular build errors I get on fluentui packages after git updates locally, too. (I've been having to do full repo cleans to resolve.. even |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
We need to specify the cwd and base in these tasks because of the move away from a centralized gulp build call (it now can be that the cwd is different than paths.base). So for caching scenarios, we need to make sure the src, cache and dest use the correct base / cwd values.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow