Skip to content

Chore/adopt latest build#12057

Merged
kenotron merged 5 commits intomicrosoft:masterfrom
miroslavstastny:chore/adopt-latest-build
Feb 26, 2020
Merged

Chore/adopt latest build#12057
kenotron merged 5 commits intomicrosoft:masterfrom
miroslavstastny:chore/adopt-latest-build

Conversation

@miroslavstastny
Copy link
Member

@miroslavstastny miroslavstastny commented Feb 25, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Add changes made to fluentui/build since the initial import to fabric/scripts.

Microsoft Reviewers: Open in CodeFlow

@ecraig12345
Copy link
Member

@size-auditor
Copy link

size-auditor bot commented Feb 25, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0903477defe918c3c1664b88444bd77508caf759 (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 702 651
BaseButton (experiments) 870 894
DefaultButton 933 928
DefaultButton (experiments) 1736 1777
DetailsRow 3186 3229
DetailsRow (fast icons) 3103 3184
DetailsRow without styles 2972 2963
DocumentCardTitle with truncation 1556 1545
MenuButton 1279 1260
MenuButton (experiments) 3247 3298
PrimaryButton 1115 1092
PrimaryButton (experiments) 1838 1836
SplitButton 2651 2698
SplitButton (experiments) 6614 6627
Stack 416 438
Stack with Intrinsic children 1014 1062
Stack with Text children 3818 3782
Text 327 342
Toggle 763 753
Toggle (experiments) 2092 2117
button 60 51

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.6 0.48 1.25:1 2000 1206
🦄 Button.Fluent 0.14 0.22 0.64:1 1000 142
🔧 Checkbox.Fluent 0.97 0.38 2.55:1 1000 970
🔧 Dialog.Fluent 0.41 0.23 1.78:1 5000 2043
🔧 Dropdown.Fluent 4.19 0.47 8.91:1 1000 4192
🔧 Icon.Fluent 0.15 0.05 3:1 5000 768
🦄 Image.Fluent 0.06 0.1 0.6:1 5000 293
🔧 Slider.Fluent 1.75 0.4 4.38:1 1000 1749
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 353
🦄 Tooltip.Fluent 0.11 16.57 0.01:1 5000 565

🔧 Needs work     🎯 On target     🦄 Amazing

All perf tests
Scenario Current PR Ticks Baseline Ticks Ratio
DropdownManyItemsPerf.default 538 362 1.49:1
Text.Fluent 353 323 1.09:1
ListWith60ListItems.default 197 183 1.08:1
TableMinimalPerf.default 755 706 1.07:1
ButtonMinimalPerf.default 149 141 1.06:1
ChatDuplicateMessagesPerf.default 448 422 1.06:1
FlexMinimalPerf.default 450 429 1.05:1
HeaderMinimalPerf.default 543 517 1.05:1
ReactionMinimalPerf.default 3141 2986 1.05:1
RefMinimalPerf.default 198 189 1.05:1
ImageMinimalPerf.default 307 294 1.04:1
LayoutMinimalPerf.default 659 633 1.04:1
LoaderMinimalPerf.default 1096 1054 1.04:1
StatusMinimalPerf.default 302 291 1.04:1
BoxMinimalPerf.default 308 298 1.03:1
ProviderMergeThemesPerf.default 1341 1308 1.03:1
ChatMinimalPerf.default 546 535 1.02:1
FormMinimalPerf.default 897 883 1.02:1
HierarchicalTreeMinimalPerf.default 1007 987 1.02:1
ListNestedPerf.default 872 853 1.02:1
MenuButtonMinimalPerf.default 1852 1816 1.02:1
TreeMinimalPerf.default 1110 1093 1.02:1
Avatar.Fluent 1206 1182 1.02:1
AccordionMinimalPerf.default 240 238 1.01:1
AttachmentMinimalPerf.default 1124 1109 1.01:1
AvatarMinimalPerf.default 630 623 1.01:1
DialogMinimalPerf.default 2036 2013 1.01:1
InputMinimalPerf.default 1149 1136 1.01:1
ListMinimalPerf.default 404 400 1.01:1
TextMinimalPerf.default 337 334 1.01:1
TooltipMinimalPerf.default 817 810 1.01:1
Checkbox.Fluent 970 964 1.01:1
Dropdown.Fluent 4192 4140 1.01:1
Slider.Fluent 1749 1726 1.01:1
CarouselMinimalPerf.default 2336 2334 1:1
DividerMinimalPerf.default 1127 1126 1:1
HeaderSlotsPerf.default 1636 1637 1:1
LabelMinimalPerf.default 1025 1021 1:1
SliderMinimalPerf.default 1712 1718 1:1
SplitButtonMinimalPerf.default 14103 14116 1:1
TextAreaMinimalPerf.default 3627 3637 1:1
CustomToolbarPrototype.default 4065 4052 1:1
ToolbarMinimalPerf.default 1069 1068 1:1
AttachmentSlotsPerf.default 3943 3963 0.99:1
CheckboxMinimalPerf.default 4463 4525 0.99:1
EmbedMinimalPerf.default 7538 7618 0.99:1
ItemLayoutMinimalPerf.default 2029 2042 0.99:1
MenuMinimalPerf.default 2390 2416 0.99:1
RadioGroupMinimalPerf.default 538 546 0.99:1
DropdownMinimalPerf.default 4091 4172 0.98:1
ListCommonPerf.default 968 985 0.98:1
PortalMinimalPerf.default 286 292 0.98:1
ProviderMinimalPerf.default 653 668 0.98:1
VideoMinimalPerf.default 851 867 0.98:1
Dialog.Fluent 2043 2090 0.98:1
Image.Fluent 293 298 0.98:1
Tooltip.Fluent 565 578 0.98:1
AlertMinimalPerf.default 667 686 0.97:1
AnimationMinimalPerf.default 595 612 0.97:1
PopupMinimalPerf.default 403 417 0.97:1
SegmentMinimalPerf.default 1500 1542 0.97:1
Button.Fluent 142 147 0.97:1
ChatWithPopoverPerf.default 608 635 0.96:1
GridMinimalPerf.default 974 1014 0.96:1
ButtonSlotsPerf.default 708 744 0.95:1
Icon.Fluent 768 805 0.95:1
IconMinimalPerf.default 359 383 0.94:1
TreeWith60ListItems.default 274 293 0.94:1

Copy link
Contributor

@kenotron kenotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - updated the yarn.lock for you

@kenotron
Copy link
Contributor

I'm looking to fix this build error:

image

with this change #12060... so when that goes in, i'll reopen this one to kick a new job

@ecraig12345 ecraig12345 reopened this Feb 25, 2020
@kenotron kenotron merged commit d35bcb2 into microsoft:master Feb 26, 2020
@ecraig12345 ecraig12345 added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants