This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(SSR): fix document usage and add project test#2330
Merged
layershifter merged 8 commits intomasterfrom Feb 10, 2020
Merged
Conversation
layershifter
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Feb 7, 2020
| } | ||
|
|
||
| actionHandlers: AccessibilityActionHandlers | ||
| context: ProviderContextPrepared |
Member
Author
There was a problem hiding this comment.
Let's finally type this thing 🚀
Collaborator
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
miroslavstastny
approved these changes
Feb 7, 2020
kenotron
added a commit
to microsoft/fluentui
that referenced
this pull request
Feb 26, 2020
* fix(typings): enable strict mode for projects (microsoft/fluent-ui-react#2323) * chore(build): Add sourcemaps to commonjs and es packages (microsoft/fluent-ui-react#2329) * fix(SSR): fix document usage and add project test (microsoft/fluent-ui-react#2330) * fix(Toolbar): focus first item each time a focused element is hidden (microsoft/fluent-ui-react#2321) * updating yarn.lock Co-authored-by: Kenneth Chau <kenotron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2182.
This PR: