Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore(build): Add sourcemaps to commonjs and es packages#2329

Merged
miroslavstastny merged 1 commit intomasterfrom
chore/add-package-source-maps
Feb 10, 2020
Merged

chore(build): Add sourcemaps to commonjs and es packages#2329
miroslavstastny merged 1 commit intomasterfrom
chore/add-package-source-maps

Conversation

@miroslavstastny
Copy link
Member

@miroslavstastny miroslavstastny commented Feb 6, 2020

In order to improve debugging experience, add sourcemapping to ts(x) to commonjs and es packages.

Before

image

After

image

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.

Changed dependencies in build/package.json

package before after
gulp-sourcemaps - ^2.6.5

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.57 0.41 1.39:1 2000 1146
🔧 Button.Fluent 1.28 0.18 7.11:1 1000 1278
🔧 Checkbox.Fluent 1.61 0.34 4.74:1 1000 1609
🔧 Dialog.Fluent 0.42 0.22 1.91:1 5000 2118
🔧 Dropdown.Fluent 4.2 0.51 8.24:1 1000 4199
🔧 Icon.Fluent 0.3 0.05 6:1 5000 1495
🔧 Image.Fluent 0.13 0.1 1.3:1 5000 645
🔧 Slider.Fluent 2.41 0.4 6.03:1 1000 2408
🔧 Text.Fluent 0.06 0.02 3:1 5000 291
🦄 Tooltip.Fluent 0.37 19.98 0.02:1 5000 1841

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ListMinimalPerf.default 868 675 1.29:1
LoaderMinimalPerf.default 2563 2052 1.25:1
DropdownManyItemsPerf.default 530 457 1.16:1
HeaderSlotsPerf.default 1369 1200 1.14:1
CustomToolbarPrototype.default 4412 3872 1.14:1
ChatDuplicateMessagesPerf.default 578 531 1.09:1
MenuButtonMinimalPerf.default 1516 1396 1.09:1
StatusMinimalPerf.default 897 824 1.09:1
VideoMinimalPerf.default 845 780 1.08:1
TextMinimalPerf.default 268 251 1.07:1
AttachmentSlotsPerf.default 3812 3602 1.06:1
RadioGroupMinimalPerf.default 405 381 1.06:1
EmbedMinimalPerf.default 6550 6227 1.05:1
FlexMinimalPerf.default 339 323 1.05:1
ImageMinimalPerf.default 495 472 1.05:1
AccordionMinimalPerf.default 201 193 1.04:1
FormMinimalPerf.default 703 674 1.04:1
SliderMinimalPerf.default 1888 1813 1.04:1
Text.Fluent 291 279 1.04:1
ItemLayoutMinimalPerf.default 1747 1688 1.03:1
LabelMinimalPerf.default 1708 1658 1.03:1
ReactionMinimalPerf.default 2490 2429 1.03:1
Icon.Fluent 1495 1450 1.03:1
BoxMinimalPerf.default 201 197 1.02:1
ChatMinimalPerf.default 1750 1723 1.02:1
RefMinimalPerf.default 148 145 1.02:1
Dialog.Fluent 2118 2085 1.02:1
Image.Fluent 645 635 1.02:1
Slider.Fluent 2408 2371 1.02:1
AvatarMinimalPerf.default 576 570 1.01:1
ButtonMinimalPerf.default 1220 1203 1.01:1
HierarchicalTreeMinimalPerf.default 786 776 1.01:1
TreeMinimalPerf.default 1008 1002 1.01:1
DropdownMinimalPerf.default 3880 3892 1:1
MenuMinimalPerf.default 1897 1905 1:1
ProviderMergeThemesPerf.default 1075 1074 1:1
CheckboxMinimalPerf.default 6891 6949 0.99:1
GridMinimalPerf.default 809 814 0.99:1
IconMinimalPerf.default 1069 1081 0.99:1
Tooltip.Fluent 1841 1868 0.99:1
AnimationMinimalPerf.default 440 450 0.98:1
ListCommonPerf.default 1167 1196 0.98:1
ProviderMinimalPerf.default 560 572 0.98:1
CarouselMinimalPerf.default 1932 1986 0.97:1
DividerMinimalPerf.default 1036 1066 0.97:1
Dropdown.Fluent 4199 4324 0.97:1
AlertMinimalPerf.default 535 555 0.96:1
PopupMinimalPerf.default 352 366 0.96:1
TextAreaMinimalPerf.default 2989 3107 0.96:1
TooltipMinimalPerf.default 2724 2838 0.96:1
ButtonSlotsPerf.default 1754 1844 0.95:1
InputMinimalPerf.default 933 987 0.95:1
ChatWithPopoverPerf.default 600 638 0.94:1
PortalMinimalPerf.default 241 259 0.93:1
HeaderMinimalPerf.default 431 469 0.92:1
Avatar.Fluent 1146 1247 0.92:1
SplitButtonMinimalPerf.default 11093 12223 0.91:1
DialogMinimalPerf.default 1736 1920 0.9:1
Button.Fluent 1278 1419 0.9:1
AttachmentMinimalPerf.default 940 1070 0.88:1
SegmentMinimalPerf.default 1147 1306 0.88:1
TableMinimalPerf.default 552 639 0.86:1
LayoutMinimalPerf.default 521 623 0.84:1
Checkbox.Fluent 1609 1906 0.84:1
ToolbarMinimalPerf.default 711 860 0.83:1

Generated by 🚫 dangerJS

@miroslavstastny miroslavstastny merged commit c347b93 into master Feb 10, 2020
@miroslavstastny miroslavstastny deleted the chore/add-package-source-maps branch February 10, 2020 08:44
kenotron added a commit to microsoft/fluentui that referenced this pull request Feb 26, 2020
* fix(typings): enable strict mode for projects (microsoft/fluent-ui-react#2323)

* chore(build): Add sourcemaps to commonjs and es packages (microsoft/fluent-ui-react#2329)

* fix(SSR): fix document usage and add project test (microsoft/fluent-ui-react#2330)

* fix(Toolbar): focus first item each time a focused element is hidden (microsoft/fluent-ui-react#2321)

* updating yarn.lock

Co-authored-by: Kenneth Chau <kenotron@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants