This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Toolbar): focus first item each time a focused element is hidden#2321
Merged
Conversation
silviuaavram
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
force-pushed
the
fix/toolbar-focus-on-hide
branch
from
74f1717 to
88d9424
Compare
silviuaavram
added
accessibility
Collaborator
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
layershifter
reviewed
Feb 7, 2020
| el.contains(this.context.target.activeElement) | ||
| ) { | ||
| if (this.containerRef.current) { | ||
| this.containerRef.current.querySelector('[tabindex]') |
Member
There was a problem hiding this comment.
Does it really work? I don't see any logic there 🤔
Let's also add somehow E2E test for this to avoid issues in future
layershifter
added
needs author feedback
jurokapsiar
reviewed
Feb 7, 2020
| el.contains(this.context.target.activeElement) | ||
| ) { | ||
| if (this.containerRef.current) { | ||
| this.containerRef.current.querySelector('[tabindex]') |
Contributor
There was a problem hiding this comment.
could you pls check if getFirstFocusable from packages\react-bindings\src\FocusZone\focusUtilities.ts would work?
silviuaavram
added
🚀 ready for review
and removed
needs author feedback
silviuaavram
force-pushed
the
fix/toolbar-focus-on-hide
branch
from
50a231a to
d944a1d
Compare
silviuaavram
force-pushed
the
fix/toolbar-focus-on-hide
branch
from
2f2c93c to
a367b5e
Compare
kolaps33
approved these changes
Feb 18, 2020
| `.${selectors.toolbarItemWrapper}:nth-child(${index + 1}) .${selectors.toolbarItem}` | ||
| const toolbar = `.${selectors.toolbar}` | ||
|
|
||
| describe('Toolbar menu overflow with wrapped first item', () => { |
Collaborator
There was a problem hiding this comment.
just small observation we have the same naming for the describe as well in the "toolbarMenuOverflow-test.ts"
kenotron
added a commit
to microsoft/fluentui
that referenced
this pull request
Feb 26, 2020
* fix(typings): enable strict mode for projects (microsoft/fluent-ui-react#2323) * chore(build): Add sourcemaps to commonjs and es packages (microsoft/fluent-ui-react#2329) * fix(SSR): fix document usage and add project test (microsoft/fluent-ui-react#2330) * fix(Toolbar): focus first item each time a focused element is hidden (microsoft/fluent-ui-react#2321) * updating yarn.lock Co-authored-by: Kenneth Chau <kenotron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2175