Skip to content

Fix some "shell" quoting bugs#3759

Merged
bwateratmsft merged 1 commit intomainfrom
bmw/quotingbugs
Dec 9, 2022
Merged

Fix some "shell" quoting bugs#3759
bwateratmsft merged 1 commit intomainfrom
bmw/quotingbugs

Conversation

@bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Dec 8, 2022

Fixes #3758. Creating as draft since the upstream PR isn't merged yet.

Things to test:

  • Windows
    • Container list and inspect
    • Image list and inspect
    • Network list and inspect
    • Volume list and inspect
    • Context list and inspect
    • .NET debug attach
    • .NET debug w/ SSL
    • Files view
    • Container actions (start, stop, remove, prune, etc.)
    • Compose subset
    • Unrelated container tooltip change
  • Unix
    • Container list and inspect
    • Image list and inspect
    • Network list and inspect
    • Volume list and inspect
    • Context list and inspect
    • .NET debug attach
    • .NET debug w/ SSL
    • Files view
      • Linux container
    • Container actions (start, stop, remove, prune, etc.)
    • Compose subset
    • Unrelated container tooltip change

@bwateratmsft bwateratmsft added this to the 1.23.2 milestone Dec 8, 2022

#### Image
{{ imageName }} ({{ substr imageId 7 12 }})
{{ image.originalName }} ({{ substr imageId 7 12 }})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this bug/PR, but this and the line below are some super easy fixes for some tooltip issues in the Containers view. Figured it was easier to just fix them than to create an issue, triage, etc. etc.

@bwateratmsft bwateratmsft marked this pull request as ready for review December 9, 2022 19:36
@bwateratmsft bwateratmsft requested a review from a team as a code owner December 9, 2022 19:36
@bwateratmsft bwateratmsft merged commit 15ce82e into main Dec 9, 2022
@bwateratmsft bwateratmsft deleted the bmw/quotingbugs branch December 9, 2022 19:42
@microsoft microsoft locked and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "copy debugger" notification still pops up when running 'Docker .Net Core Attach (Preview)' configuration again

3 participants