Gate AgentHostTerminalContribution on chat.agentHost.enabled#311309
Merged
connor4312 merged 2 commits intomainfrom Apr 20, 2026
Merged
Gate AgentHostTerminalContribution on chat.agentHost.enabled#311309connor4312 merged 2 commits intomainfrom
connor4312 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents “Agent Host Terminal (Local)” from appearing in the terminal dropdown when the local agent host feature is disabled via the chat.agentHost.enabled setting, matching the intended UX for the agent host feature flag.
Changes:
- Gate
AgentHostTerminalContributioninitialization logic onchat.agentHost.enabled. - Add configuration service dependency to read the setting at contribution startup.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostTerminalContribution.ts | Early-return from the contribution when chat.agentHost.enabled is false so the local agent host terminal entry isn’t registered/shown. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Contributor
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Light
| Before | After |
|---|---|
 |
 |
Member
|
Moving to 1.118.0 |
connor4312
reviewed
Apr 20, 2026
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/ac7e641b-4889-4e5e-a31e-b5ab11e57e67 Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>
connor4312
approved these changes
Apr 20, 2026
rzhao271
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #311308
/cc @connor4312 @meganrogge