Merged
Conversation
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 15, 2023
* malloc: fix the memory allocation tracking to be precise (fixes mirage/ocaml-solo5#126 reported by @hannesm, mirage/ocaml-solo5#127 @palainp)
Member
|
thanks a lot for your investigations, quick reply, and prompt fix :) |
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
* malloc: fix the memory allocation tracking to be precise (fixes mirage/ocaml-solo5#126 reported by @hannesm, mirage/ocaml-solo5#127 @palainp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix #126 . An incorrect memory usage tracing was in use before, which might lose some bytes when a realloc call comes.