Skip to content

new release: ocaml-solo5 0.8.2#24799

Merged
avsm merged 1 commit intoocaml:masterfrom
hannesm:ocaml-solo5-0.8.2
Nov 16, 2023
Merged

new release: ocaml-solo5 0.8.2#24799
avsm merged 1 commit intoocaml:masterfrom
hannesm:ocaml-solo5-0.8.2

Conversation

@hannesm
Copy link
Member

@hannesm hannesm commented Nov 15, 2023

* malloc: fix the memory allocation tracking to be precise (fixes mirage/ocaml-solo5#126 reported by @hannesm, mirage/ocaml-solo5#127 @palainp)
@hannesm
Copy link
Member Author

hannesm commented Nov 15, 2023

The lint failures: indeed, there's a dune-project file in the repository (I'm not sure why). But the entire project does not depend on dune. (The dune-project file is helpful for CI of the examples).

The lower-bound failures: some solo5 releases contain -Werror and that fails with more modern C compilers. Nothing I can do about it (in this PR).

@hannesm hannesm closed this Nov 15, 2023
@hannesm hannesm reopened this Nov 15, 2023
@hannesm
Copy link
Member Author

hannesm commented Nov 16, 2023

so, after the CI run -- this is fine to be merged.

@avsm
Copy link
Member

avsm commented Nov 16, 2023

Thanks for the triage! Looks good to merge.

@avsm avsm merged commit ab3b89b into ocaml:master Nov 16, 2023
@hannesm hannesm deleted the ocaml-solo5-0.8.2 branch November 16, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On hvt, I sometimes get a negative reading from malloc_memory_usage

3 participants