Merged
Conversation
Member
hannesm
commented
Nov 15, 2023
- malloc: fix the memory allocation tracking to be precise (fixes On hvt, I sometimes get a negative reading from malloc_memory_usage mirage/ocaml-solo5#126 reported by @hannesm, Fix used memory estimation mirage/ocaml-solo5#127 @palainp)
* malloc: fix the memory allocation tracking to be precise (fixes mirage/ocaml-solo5#126 reported by @hannesm, mirage/ocaml-solo5#127 @palainp)
Member
Author
|
The lint failures: indeed, there's a The lower-bound failures: some solo5 releases contain -Werror and that fails with more modern C compilers. Nothing I can do about it (in this PR). |
Member
Author
|
so, after the CI run -- this is fine to be merged. |
Member
|
Thanks for the triage! Looks good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.