Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2227 +/- ##
===========================================
+ Coverage 30.91% 41.20% +10.29%
===========================================
Files 53 53
Lines 20112 20472 +360
Branches 9755 9680 -75
===========================================
+ Hits 6217 8436 +2219
- Misses 7922 8048 +126
+ Partials 5973 3988 -1985 ☔ View full report in Codecov by Sentry. |
Collaborator
Do we need to report to the upstream? |
Collaborator
|
it has been, see zip-rs/zip2#231 |
Collaborator
|
and zip-rs/zip2#247 for the potential fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This, unfortunately, comes with a massive performance regression: 25% ! So, PLEASE DO NOT MERGE.