Closed
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
===========================================
+ Coverage 30.91% 51.16% +20.25%
===========================================
Files 53 55 +2
Lines 20112 20749 +637
Branches 9755 9900 +145
===========================================
+ Hits 6217 10617 +4400
- Misses 7922 8085 +163
+ Partials 5973 2047 -3926 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Hi, @sylvestre, I think it's time for us to cut off a new release. I expect to see #2234 happen in |
Contributor
|
Hi @Xuanwo, Should we resolve conflicts for next merging? |
Collaborator
|
yes, please fix the conflicts |
AJIOB
reviewed
Sep 6, 2024
| # by default which pulls in an outdated failure version | ||
| which = { version = "6", default-features = false } | ||
| zip = { version = "0.6", default-features = false } | ||
| zip = { version = "2", default-features = false } |
Contributor
There was a problem hiding this comment.
Is the problem from #2227 still persist?
If yes, please, try to find the 2.x.y version, that works.
The similar issue on the original repository: zip-rs/zip2#231
Collaborator
Author
|
This PR is not needed anymore, closing... |
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will bump deps to latest.