Skip to content

JSON updates for 1.04.05#388

Open
mregen wants to merge 8 commits intomainfrom
jsonupdates
Open

JSON updates for 1.04.05#388
mregen wants to merge 8 commits intomainfrom
jsonupdates

Conversation

@mregen
Copy link
Owner

@mregen mregen commented Mar 21, 2025

Proposed changes

Latest spec updates

opcfoundation-org and others added 2 commits March 21, 2025 09:24
* Add missing constants for JSON encoding.

* Update generated files to 1.05.04.

* Update NuGets

* Fix compile errors due to abstract types.

* Update nodesets.

* Update JSON Encoder/Decoder.

* Update with JSON encoder.

* Change prefix char.

* Change prefix to uppercase.

* Fix JsonEncoder

* Fix null pointer.

* Update encoders to suppress artifacts.

* JSON encoding fixes.

* Fix JSON RawEncoding

* Update JSON encoders.

* Revert changes for Matrix in Variant.

* Update NodeSet.

* Resolve name conflict with new Opc.Ua types.

* Fix failing Tests

* Fix unit tests after change to Verbose/Compact encoding.

* Add final 1.05.04 generated classes and unit test fixes.

* Fix more unit tests.

* Update NodeSet to released version.

* Remove unintended changes to UANodeSet.xsd

* Update Schema/UANodeSet.xsd

* Merge breaking changes to JsonEncoder.cs from develop/main374

* Allow JObject in ExtensionObjects.

* fix version json

* Update generated files to UA-1.05.04-2025-01-08

* Some cleanup of the new APIs and Union implementation. (OPCFoundation#2927)

* Some cleanup of the new APIs and Union implementation.

* fix build

* Handle status code Uncertain according to the specification (OPCFoundation#2898)

* OPCFoundation#2896: Write output arguments for good and uncertain status code

When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification.

* OPCFoundation#2896: The service result corresponds the method call result

The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior.

* Add SetHiResClockDisabled  & fix Rejected Store Creation in ApplicationConfigurationBuilder (OPCFoundation#2909)

Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder
Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier

* revert based on feedback

* move some logic from class code to encoder/decoder

* Fix race condition on Nuget build (OPCFoundation#2930)

- nodeset xmlzip is created in obj folders if multiple targets are built in parallel

* update common comments

* Update NodeSet files.

* Fix ReadSwitchField Implementation.

* Make UserIdentity.DisplayName writeable.

* Fix merge failures.

* Fix XmlElement encoding and bad NamespaceIndex fallback logic.

* Fix 2D array raw encoding.

* Add support for DesignToolOnly.

---------

Co-authored-by: Randy Armstrong <randy@sparhawksoftware.com>
Co-authored-by: Martin Regen <mregen@microsoft.com>
Co-authored-by: Martin Regen <7962757+mregen@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 252 lines in your changes missing coverage. Please review.

Project coverage is 54.86%. Comparing base (124285d) to head (9a1be78).

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 51.90% 158 Missing and 19 partials ⚠️
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 65.48% 52 Missing and 16 partials ⚠️
Stack/Opc.Ua.Core/Types/BuiltIn/ExtensionObject.cs 0.00% 2 Missing and 2 partials ⚠️
...c.Ua.Client.ComplexTypes/Types/UnionComplexType.cs 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   54.94%   54.86%   -0.08%     
==========================================
  Files         349      349              
  Lines       66487    66788     +301     
  Branches    13637    13757     +120     
==========================================
+ Hits        36529    36645     +116     
- Misses      25979    26154     +175     
- Partials     3979     3989      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants