Introduce anti-censorship section in vpn settings

[kl]

---

This change is 

[linear]

DROID-2314 Introduce "Anti censorship" section in vpn settings

[Rawa]

Only minor remarks. I've reviewed all Android code, very well done, looks very nice! @kl 👏

@Rawa reviewed 111 of 111 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/AntiCensorshipSettingsViewModel.kt line 65 at r1 (raw file):

    fun onSelectObfuscationMode(obfuscationMode: ObfuscationMode) {
        Logger.e("Select obfuscation mode $obfuscationMode")

Reminder to remove this log.

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/AntiCensorshipSettingsScreenTest.kt line 82 at r1 (raw file):

            // Assert
            apply {

apply is not necessary, right?

---

android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/VpnSettingsViewModelTest.kt line 69 at r1 (raw file):

    private val mockSettingsUpdate = MutableStateFlow<Settings?>(null)
    //    private val portRangeFlow = MutableStateFlow(emptyList<PortRange>())

Reminder to remove these commented lines if not necessary

[kl]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/AntiCensorshipSettingsScreenTest.kt line 82 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

apply is not necessary, right?

Done.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/AntiCensorshipSettingsViewModel.kt line 65 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Reminder to remove this log.

Done.

---

android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/VpnSettingsViewModelTest.kt line 69 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Reminder to remove these commented lines if not necessary

Done.

[Rawa]

@Rawa reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Pururun]

@Pururun reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SelectPortViewModel.kt line 137 at r2 (raw file):

                PortTypeUiState(
                    presetPorts = SHADOWSOCKS_PRESET_PORTS,
                    allowedPortRanges = shadowsocksPortRanges,

This needs to be all available ports otherwise users are blocked from setting a shadowsocks port that is valid for some servers. We should however show a text that shows which ports will work on all servers, but it can not be an invalid setting.

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SelectPortViewModel.kt line 137 at r2 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This needs to be all available ports otherwise users are blocked from setting a shadowsocks port that is valid for some servers. We should however show a text that shows which ports will work on all servers, but it can not be an invalid setting.

After internal discussion it was decided that we should just do as it currently is in the app and the use the hardcoded SHADOWSOCKS_AVAILABLE_PORTS instead of the ports we get from the relay list.

[kl]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SelectPortViewModel.kt line 137 at r2 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This needs to be all available ports otherwise users are blocked from setting a shadowsocks port that is valid for some servers. We should however show a text that shows which ports will work on all servers, but it can not be an invalid setting.

Done.

[Rawa]

@Rawa reviewed 89 of 89 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

[Pururun]

@Pururun reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

@Rawa reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

@Rawa reviewed 12 of 96 files at r6.
Reviewable status: 46 of 134 files reviewed, all discussions resolved

[Rawa]

@Rawa reviewed 80 of 96 files at r6.
Reviewable status: 74 of 134 files reviewed, all discussions resolved

[Rawa]

@Rawa reviewed 2 of 96 files at r6, 41 of 59 files at r7, 59 of 59 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Pururun]

@Pururun reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Serock3]

@Serock3 reviewed 1 of 96 files at r6, 21 of 59 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved