Skip to content

fix: update bulk action prefix to myparcelcom#1559

Open
GravendeelJochem wants to merge 1 commit intomainfrom
fix/bulk-action-fix
Open

fix: update bulk action prefix to myparcelcom#1559
GravendeelJochem wants to merge 1 commit intomainfrom
fix/bulk-action-fix

Conversation

@GravendeelJochem
Copy link
Contributor

INT-1407

Copilot AI review requested due to automatic review settings February 13, 2026 09:45
@codecov
Copy link

codecov bot commented Feb 13, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
147 1 146 0
View the full list of 1 ❄️ flaky test(s)
src/components/pdk/components.spec.ts::src/components/pdk/components.spec.ts

Flake rate in main: 100.00% (Passed 0 times, Failed 10 times)

Stack Traces | 0s run time
Error: [🍍]: "getActivePinia()" was called but there was no active Pinia. Are you trying to use a store before calling "app.use(pinia)"?
See https://pinia.vuejs.org/core-concepts/outside-component-usage.html for help.
This will fail in production.
 ❯ Module.useStore ../../../node_modules/@.../pinia/dist/pinia.mjs:1741:19
 ❯ runModalTest ../../../node_modules/@.../src/components/runModalTest.ts:7:44
 ❯ ../../../node_modules/@.../src/tests/executeAdminComponentTest.ts:29:7

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the WooCommerce admin bulk-action listener to recognize the new plugin/app prefix (myparcelcom), aligning the frontend hook with the bulk action identifiers used in the admin UI.

Changes:

  • Update the bulk action prefix from myparcelnl to myparcelcom in the admin bulk-action listener.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

import {AdminAction, useActionStore} from '@myparcel-dev/pdk-admin';

const BULK_ACTION_PREFIX = 'myparcelnl';
const BULK_ACTION_PREFIX = 'myparcelcom';
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bulk-action value prefix is generated server-side using Pdk::getAppInfo()->name (see PdkOrderListHooks::registerBulkActions()), so hardcoding 'myparcelcom' here can get out of sync if the app name ever changes. Consider deriving the prefix from useAppInfo().name so the JS listener always matches the PHP-registered bulk actions.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants