Skip to content

fix: update bulk action prefix to myparcelcom #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GravendeelJochem wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update bulk action prefix to myparcelcom #1559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/backend/admin/src/hooks/listenForBulkActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {AdminAction, useActionStore} from '@myparcel-dev/pdk-admin';

const BULK_ACTION_PREFIX = 'myparcelnl';
const BULK_ACTION_PREFIX = 'myparcelcom';
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bulk-action value prefix is generated server-side using Pdk::getAppInfo()->name (see PdkOrderListHooks::registerBulkActions()), so hardcoding 'myparcelcom' here can get out of sync if the app name ever changes. Consider deriving the prefix from useAppInfo().name so the JS listener always matches the PHP-registered bulk actions.

Copilot uses AI. Check for mistakes.

const BULK_ACTION_MAP = Object.freeze({
action_edit: AdminAction.OrdersEdit,
Expand Down
Loading