chore(typing): relax from_dict to use Mapping#2022
Merged
dangotbanned merged 2 commits intomainfrom Feb 16, 2025
Merged
Conversation
Current `dict[str, Any]` will reject `Mapping[str, Sequence[Any]]` - https://github.com/vega/altair/blob/ddda22c50f7265728dcec26afec02d6d0dbda189/altair/datasets/_cache.py#L182 https://github.com/vega/altair/blob/ddda22c50f7265728dcec26afec02d6d0dbda189/altair/datasets/_reader.py#L362-L366
dangotbanned
added a commit
that referenced
this pull request
Feb 16, 2025
- Similar to #2022 - There's more variation between backends here, so `pandas` and `pyarrow` still convert `Sequence` -> `list` to be safe
10 tasks
EdAbati
approved these changes
Feb 16, 2025
Member
Author
|
Thanks @EdAbati |
dangotbanned
added a commit
to dangotbanned/altair
that referenced
this pull request
Sep 11, 2025
dangotbanned
added a commit
to vega/altair
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below
Current
dict[str, Any]will rejectMapping[str, Sequence[Any]].I noticed this in
altair, where I needed to cast todict[str, Any]:For reference,
polars.from_dictusesMappingbut with some constraints on the value type