Skip to content

chore(typing): relax from_dict to use Mapping #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangotbanned merged 2 commits into from
Feb 16, 2025
Merged

chore(typing): relax from_dict to use Mapping #2022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9e2dd0
chore(typing): relax `from_dict` to `Mapping`
dangotbanned Feb 16, 2025
87e47e6
chore(typing): backport to `v1.from_dict`
dangotbanned Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions narwhals/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from typing import Any
from typing import Iterable
from typing import Literal
from typing import Mapping
from typing import Protocol
from typing import Sequence
from typing import TypeVar
Expand Down Expand Up @@ -291,8 +292,8 @@ def _new_series_impl(


def from_dict(
data: dict[str, Any],
schema: dict[str, DType] | Schema | None = None,
data: Mapping[str, Any],
schema: Mapping[str, DType] | Schema | None = None,
*,
backend: ModuleType | Implementation | str | None = None,
native_namespace: ModuleType | None = None,
Expand Down Expand Up @@ -348,8 +349,8 @@ def from_dict(


def _from_dict_impl(
data: dict[str, Any],
schema: dict[str, DType] | Schema | None = None,
data: Mapping[str, Any],
schema: Mapping[str, DType] | Schema | None = None,
*,
backend: ModuleType | Implementation | str | None = None,
) -> DataFrame[Any]:
Expand Down
5 changes: 3 additions & 2 deletions narwhals/stable/v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@

if TYPE_CHECKING:
from types import ModuleType
from typing import Mapping

from typing_extensions import Self

Expand Down Expand Up @@ -2169,8 +2170,8 @@ def from_arrow(


def from_dict(
data: dict[str, Any],
schema: dict[str, DType] | Schema | None = None,
data: Mapping[str, Any],
schema: Mapping[str, DType] | Schema | None = None,
*,
backend: ModuleType | Implementation | str | None = None,
native_namespace: ModuleType | None = None,
Expand Down
Loading