Skip to content

ci: Temporary pin duckdb for ibis#3136

Merged
FBruzzesi merged 2 commits intomainfrom
ci/temp-pin-duckdb
Sep 18, 2025
Merged

ci: Temporary pin duckdb for ibis#3136
FBruzzesi merged 2 commits intomainfrom
ci/temp-pin-duckdb

Conversation

@FBruzzesi
Copy link
Copy Markdown
Member

@FBruzzesi FBruzzesi commented Sep 18, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related

If you have comments or can explain your changes, please do so below

Temp pin to make CI green/runnable - the drawback is that we are not testing duckdb 1.4 in the main test suite at all?

@FBruzzesi FBruzzesi added the ci label Sep 18, 2025
@FBruzzesi FBruzzesi changed the title ci: Temporary pin duckdb with ibis ci: Temporary pin duckdb for ibis Sep 18, 2025
@dangotbanned dangotbanned added duckdb Issue is related to duckdb backend ibis Issue is related to ibis backend labels Sep 18, 2025
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FBruzzesi

This seems to be the only reasonable option and also what other projects are doing (see Related)

praise be narwhal

@dangotbanned
Copy link
Copy Markdown
Member

the drawback is that we are not testing duckdb 1.4 in the main test suite at all?

We are at least testing against nightly though, right?

uv pip install -U --pre duckdb --system

@dangotbanned
Copy link
Copy Markdown
Member

Important

Could you open an issue to remind us to revert later please?

@dangotbanned
Copy link
Copy Markdown
Member

The tea tasting failures seem to have the same origin.
Not sure if we should be doing anything to fix that though?

@FBruzzesi FBruzzesi mentioned this pull request Sep 18, 2025
5 tasks
@FBruzzesi
Copy link
Copy Markdown
Member Author

The tea tasting failures seem to have the same origin. Not sure if we should be doing anything to fix that though?

pinned in b371513

@FBruzzesi FBruzzesi merged commit ba40f30 into main Sep 18, 2025
29 of 31 checks passed
@FBruzzesi FBruzzesi deleted the ci/temp-pin-duckdb branch September 18, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci duckdb Issue is related to duckdb backend ibis Issue is related to ibis backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants