Merged
Conversation
Member
This comment was marked as off-topic.
This comment was marked as off-topic.
dangotbanned
added
duckdb
2 tasks
dangotbanned
approved these changes
Oct 9, 2025
Member
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
Thanks @FBruzzesi
I couldn't tell if this means we can close (#3137) or if that still needs an ibis release - but this all LGTM
Member
Author
Yes we definitely still need the ibis release. I know tea-tasting made the pin on its side for now, that's why I was able to un-pin it there |
Member
|
we could just install ibis directly from github? |
Member
|
anyway, thanks! |
dangotbanned
added a commit
that referenced
this pull request
Oct 12, 2025
Suggested by @MarcoGorelli in #3186 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
If you have comments or can explain your changes, please do so below
Trying my luck here