Skip to content

Comments

(2.12) [FIXED] Remove recovered streams/consumers if not in catchup meta snapshot#7824

Merged
neilalexander merged 1 commit intomainfrom
maurice/rm-recovered
Feb 13, 2026
Merged

(2.12) [FIXED] Remove recovered streams/consumers if not in catchup meta snapshot#7824
neilalexander merged 1 commit intomainfrom
maurice/rm-recovered

Conversation

@MauriceVanVeen
Copy link
Member

TestJetStreamClusterDeleteConsumerWhileServerDown (and others) would fail if the restarted server couldn't install a snapshot during shutdown. This happened if the server was a follower of the meta layer and committed the consumer create from a heartbeat, which isn't stored in the log. So, when the server restarted it didn't know it could commit/apply this consumer create again (since it already did so prior to restart). Then, when the meta snapshot was received to catch this server up, it would not properly remove the consumer as it wasn't tracked in its assignments.

Marked as 2.12+ as #7540 is only cherry-picked there.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner February 13, 2026 11:05
…eta snapshot

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 7a91522 into main Feb 13, 2026
90 of 92 checks passed
@neilalexander neilalexander deleted the maurice/rm-recovered branch February 13, 2026 11:50
neilalexander added a commit that referenced this pull request Feb 17, 2026
Follow-up of #7824. Aligning
and simplifying the cleanup of orphaned streams and consumers with
`checkForOrphans`.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander added a commit that referenced this pull request Feb 20, 2026
Includes the following:

- #7839
- #7843
- #7824
- #7826
- #7845
- #7844
- #7840
- #7827
- #7846
- #7848
- #7849
- #7855
- #7850
- #7857
- #7856

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants