Skip to content

Comments

Allow optional window_size for stream snapshot flow control#7839

Merged
neilalexander merged 1 commit intomainfrom
neil/streamsnapshotwnd
Feb 17, 2026
Merged

Allow optional window_size for stream snapshot flow control#7839
neilalexander merged 1 commit intomainfrom
neil/streamsnapshotwnd

Conversation

@neilalexander
Copy link
Member

Being able to specify the chunk size allows controlling how many messages are in-flight within a fixed 8MB window, and how often acks are required, but it doesn't allow reducing the window size to cope with very slow connections. Instead we'll allow accepting window_size as an optional parameter to allow decreasing this as low as 1KB or as high as 32MB.

The defaults have not changed.

Signed-off-by: Neil Twigg neil@nats.io

Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander marked this pull request as ready for review February 17, 2026 15:53
@neilalexander neilalexander requested a review from a team as a code owner February 17, 2026 15:53
@neilalexander neilalexander merged commit 2a3e1a4 into main Feb 17, 2026
69 of 70 checks passed
@neilalexander neilalexander deleted the neil/streamsnapshotwnd branch February 17, 2026 16:01
neilalexander added a commit that referenced this pull request Feb 17, 2026
Allows CLI to correctly detect when `window_size` from #7839 is
supported or not.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander mentioned this pull request Feb 17, 2026
neilalexander added a commit that referenced this pull request Feb 17, 2026
Allows CLI to correctly detect when `window_size` from #7839 is
supported or not.

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Feb 20, 2026
Allows CLI to correctly detect when `window_size` from #7839 is
supported or not.

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Feb 20, 2026
Includes the following:

- #7839
- #7843
- #7824
- #7826
- #7845
- #7844
- #7840
- #7827
- #7846
- #7848
- #7849
- #7855
- #7850
- #7857
- #7856

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants