Preserve paused leases across engine auth resume

[henrypark133]

Summary

• persist paused_lease through pending gate creation, storage, and replay
• prefer the paused lease when resuming gated engine actions instead of re-deriving a fresh lease
• keep successful OAuth callbacks from clearing the pending engine auth gate before replay completes

Verification

• CARGO_TARGET_DIR=/Users/henry/near_ai/near_claw/ironclaw-ci-regression-fix-2/.shared-target cargo test -p ironclaw_engine parse_outcome_gate_paused
• CARGO_TARGET_DIR=/Users/henry/near_ai/near_claw/ironclaw-ci-regression-fix-2/.shared-target cargo test -p ironclaw_engine normalize_pause_outcome_transitions_thread_to_waiting

[gemini-code-assist]

Code Review

This pull request implements the persistence and reuse of capability leases when an execution is paused by a gate. It adds a "paused_lease" field to the ThreadOutcome, EngineError, and PendingGate structures, allowing the engine to restore the specific lease context upon resumption. The changes span the orchestrator, scripting, and structured executors, as well as the bridge and gateway logic, including a refactor of the OAuth callback handler to use a dedicated dispatch function. I have no feedback to provide.

[ilblackdragon]

Rebased onto latest `origin/staging` and addressed the two issues blocking merge. Marked ready for review.

Rebase notes

Conflict shape: the PR touched `src/channels/web/server.rs` but since it was authored, PR #2645 (stage 4a) extracted the OAuth callback into `src/channels/web/features/oauth/mod.rs`. Cherry-picked the engine/bridge/gate changes cleanly (they applied auto-merge) and re-applied the server.rs changes surgically to the new post-refactor location:

• Split `clear_auth_mode_for_thread` in `server.rs` into two: the public helper still clears both legacy session + engine pending auth, and a new `clear_session_auth_mode_for_thread` clears only the session half. Both `pub(crate)` so `features/oauth/` can reach them.
• Updated `features/oauth/mod.rs::oauth_callback_handler` to call `clear_session_auth_mode_for_thread(..., None)` instead of `clear_auth_mode(...)`, preserving the engine gate across the callback so the `ExternalCallback` replay path can resolve it (preserving the paused_lease).

Deliberately did not port the PR's `dispatch_engine_external_callback` helper refactor — that helper lives in `platform/engine_dispatch.rs` which is introduced by the not-yet-merged PR #2665 (stage 4b). The inline `tx.send` flow stays for now; rolling up the refactor into this PR would couple it to #2665's merge order.

Clippy fix

Adding `paused_lease` to the `ThreadOutcome::GatePaused` variant tipped three clippy `large_enum_variant` lints past the threshold (lint fires at ~200 bytes, `CapabilityLease` is ~360 bytes):

1. `ThreadOutcome::GatePaused` itself
2. `ThreadSignal::ChildCompleted { outcome: ThreadOutcome }` (transitively)
3. `PreflightResult::GatePaused(ThreadOutcome)` (transitively)

Fixed by boxing `paused_lease` in `ThreadOutcome::GatePaused` — matches what the PR already does in `EngineError::GatePaused`. The single consumer that stores it unboxed (`PendingGate.paused_lease`) gets an inline `paused_lease.map(|b| *b)` unbox at the assignment site in `router.rs`.

Verification

• `cargo fmt` ✓
• `cargo clippy -p ironclaw_engine --all-targets -- -D warnings` → 0 warnings
• `cargo clippy --all --benches --tests --examples --all-features` → 0 warnings
• `cargo test -p ironclaw_engine parse_outcome_gate_paused` → ok (the PR's named test)
• `cargo test -p ironclaw_engine normalize_pause_outcome_transitions_thread_to_waiting` → ok (the PR's other named test)
• `cargo test -p ironclaw_engine` → all pass
• `cargo test --test engine_v2_gate_integration` → all pass (including the PR's new gate test)
• `cargo test -p ironclaw --lib` → 5158 passed. 1 flake on `extensions::manager::tests::test_telegram_token_colon_preserved_in_validation_url` — known flake (Flaky test: test_telegram_token_colon_preserved_in_validation_url leaks across parallel runs #2102), passes in isolation, pre-existing.

Engine v2 default critical path

With #2452 already merged and this PR ready, only #2622 (unify v2 extension auth resume flow) remains before the default flip. It's also DIRTY and needs rebase; happy to rebase that next if you want me to keep unblocking.

[Copilot]

Pull request overview

Updates engine v2 gate handling to persist and reuse the original capability lease across auth-gated pauses/resumes, and adjusts web OAuth callback cleanup so the engine pending-auth gate remains until replay completes.

Changes:

• Add paused_lease plumbing across ThreadOutcome::GatePaused, EngineError::GatePaused, and persisted PendingGate state.
• Prefer paused_lease when replaying/resuming a pending gate action instead of re-deriving a lease.
• Split legacy session auth cleanup from engine gate cleanup to avoid clearing the engine pending-auth gate in OAuth callbacks before replay finishes.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/engine_v2_gate_integration.rs	Updates test fixtures to include the new paused_lease field.
src/gate/store.rs	Updates pending-gate store tests to include paused_lease.
src/gate/persistence.rs	Updates persistence tests to include paused_lease.
src/gate/pending.rs	Adds paused_lease to persisted PendingGate model.
src/channels/web/server.rs	Splits auth cleanup into “session only” vs “session + engine gate” helpers.
src/channels/web/features/oauth/mod.rs	Uses session-only cleanup in OAuth callback to preserve engine gate until replay.
src/bridge/router.rs	Persists paused_lease into pending gates and prefers it during resume/replay.
src/bridge/effect_adapter.rs	Captures the current lease snapshot into GatePaused errors.
src/agent/agent_loop.rs	Allows ExternalCallback submissions to target a thread UUID similarly to approvals.
crates/ironclaw_engine/src/types/error.rs	Extends EngineError::GatePaused with paused_lease.
crates/ironclaw_engine/src/runtime/mission.rs	Updates test fixtures to include paused_lease.
crates/ironclaw_engine/src/runtime/messaging.rs	Extends ThreadOutcome::GatePaused with boxed paused_lease.
crates/ironclaw_engine/src/executor/structured.rs	Propagates paused_lease through GatePaused result classification and parsing.
crates/ironclaw_engine/src/executor/scripting.rs	Updates preflight GatePaused construction to include paused_lease.
crates/ironclaw_engine/src/executor/orchestrator.rs	Logs/serializes paused_lease, parses it from tool results, and adds a parsing test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

When resuming a pending gate, pending.paused_lease is used directly without any validation (thread_id match / action coverage / revocation / expiry). This bypasses the normal LeaseManager::find_lease_for_action checks and could allow resuming with a stale or mismatched lease. Consider validating that the snapshot lease applies to pending.thread_id and pending.action_name (and is not revoked/expired), otherwise fall back to find_lease_for_action or fail closed.

Suggested change

	let lease = if let Some(lease) = pending.paused_lease.clone() {
	lease
	} else {
	state
	.thread_manager
	.leases
	.find_lease_for_action(pending.thread_id, &pending.action_name)
	.await
	.ok_or_else(|| {
	engine_err(
	"resume lease",
	format!("no active lease covers action '{}'", pending.action_name),
	)
	})?
	};
	let lease = state
	.thread_manager
	.leases
	.find_lease_for_action(pending.thread_id, &pending.action_name)
	.await
	.ok_or_else(|| {
	engine_err(
	"resume lease",
	format!("no active lease covers action '{}'", pending.action_name),
	)
	})?;

[ilblackdragon]

Fixed in eaf91a42. Extracted the lease-picking into a standalone resume_lease_for_pending_gate(pending, leases) helper that now validates the snapshot before use: thread_id match, action coverage, !revoked, and expires_at in the future. If any check fails, falls through to LeaseManager::find_lease_for_action — the snapshot is still preferred when valid (the original bug: no active lease at resume after restart) but stale snapshots no longer silently bypass revocation/expiry.

[Copilot]

The new resume path that prefers pending.paused_lease over re-deriving via LeaseManager is a key behavioral change but doesn’t appear to be covered by a router-level test. Adding a test that reproduces the regression (e.g., paused action where no active lease exists at resume, but paused_lease allows completion) would help prevent future breaks.

[ilblackdragon]

Fixed in eaf91a42. Added 6 libsql-free tests in bridge::router::tests driving resume_lease_for_pending_gate end-to-end:

• resume_lease_prefers_snapshot_even_when_lease_manager_empty — pins the original bug fix.
• resume_lease_rejects_revoked_snapshot_and_falls_back — revoked snapshot + live lease → use live.
• resume_lease_rejects_expired_snapshot_and_falls_back — expired snapshot + live lease → use live.
• resume_lease_rejects_snapshot_with_wrong_thread_id — defensive: drift between snapshot and pending.
• resume_lease_rejects_snapshot_missing_action_coverage — lease must actually grant the pending action.
• resume_lease_returns_none_when_no_snapshot_and_no_active_lease — clean None for caller's error path.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Including Submission::ExternalCallback in approval_thread_uuid resolution can mutate sess.active_thread based solely on conversation_scope even when the request_id doesn’t match any pending auth gate. A crafted JSON ExternalCallback (parsed from message content) can therefore switch the user’s active thread and then fail with "No matching pending authentication gate found." Consider preventing thread switching unless the callback is known-valid for that thread (e.g., look up the pending gate by request_id first and only then set active_thread), or gate this cross-thread routing to trusted/internal submissions only.