Skip to content

chore: promote staging to staging-promote/95dcf807-24717849306 (2026-04-21 11:13 UTC)#2785

Merged
henrypark133 merged 2 commits into
mainfrom
staging-promote/edbf0eaa-24719068222
Apr 29, 2026
Merged

chore: promote staging to staging-promote/95dcf807-24717849306 (2026-04-21 11:13 UTC)#2785
henrypark133 merged 2 commits into
mainfrom
staging-promote/edbf0eaa-24719068222

Conversation

@ironclaw-ci
Copy link
Copy Markdown
Contributor

@ironclaw-ci ironclaw-ci Bot commented Apr 21, 2026

Auto-promotion from staging CI

Batch range: 7fb41555a9e55677d1aaea29ca567a5b369c2b05..edbf0eaaa173c721db867776f363a649d55d7f70
Promotion branch: staging-promote/edbf0eaa-24719068222
Base: staging-promote/95dcf807-24717849306
Triggered by: Staging CI batch at 2026-04-21 11:13 UTC

Commits in this batch (61):

Current commits in this promotion (2)

Current base: staging-promote/95dcf807-24717849306
Current head: staging-promote/edbf0eaa-24719068222
Current range: origin/staging-promote/95dcf807-24717849306..origin/staging-promote/edbf0eaa-24719068222

Auto-updated by staging promotion metadata workflow

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

* fix(engine-v2): recover flattened tool calls

* fix: address review findings (iteration 1)

* fix: address review findings (iteration 1)
* fix(engine): stop failed missions from respawning (#2736)

* fix(engine): address henrypark133 review — allow failed mission resume (#2760)
@github-actions github-actions Bot added scope: llm LLM integration size: L 200-499 changed lines risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Apr 21, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Apr 21, 2026

Code review

Found 1 issue:

[LOW:50] Unnecessary clone of tools vector at line 163 — tools is created fresh on each LLM request and cloned for the ToolCompletionRequest. Consider passing by reference or avoiding the allocation.

All other aspects reviewed:

  • Mission lifecycle changes are well-designed with comprehensive test coverage
  • Tool call recovery logic is sound with proper error handling
  • No unwrap()/expect() in production code
  • Thread state transitions are correct
  • Tests provide good regression coverage for both failed mission handling and flattened tool call recovery

Base automatically changed from staging-promote/95dcf807-24717849306 to main April 29, 2026 04:09
@henrypark133 henrypark133 merged commit edbf0ea into main Apr 29, 2026
141 of 150 checks passed
@henrypark133 henrypark133 deleted the staging-promote/edbf0eaa-24719068222 branch April 29, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules scope: llm LLM integration size: L 200-499 changed lines staging-promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants