chore: promote staging to staging-promote/95dcf807-24717849306 (2026-04-21 11:13 UTC)#2785
Merged
Merged
Conversation
* fix(engine-v2): recover flattened tool calls * fix: address review findings (iteration 1) * fix: address review findings (iteration 1)
Code reviewFound 1 issue: [LOW:50] Unnecessary clone of tools vector at line 163 — tools is created fresh on each LLM request and cloned for the ToolCompletionRequest. Consider passing by reference or avoiding the allocation. All other aspects reviewed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-promotion from staging CI
Batch range:
7fb41555a9e55677d1aaea29ca567a5b369c2b05..edbf0eaaa173c721db867776f363a649d55d7f70Promotion branch:
staging-promote/edbf0eaa-24719068222Base:
staging-promote/95dcf807-24717849306Triggered by: Staging CI batch at 2026-04-21 11:13 UTC
Commits in this batch (61):
onboardfails with "Failed to save settings to database", butironclawstarts successfully and applies migrations #846) (fix(setup): run migrations during onboard when DATABASE_URL preset (#846) #2309)Current commits in this promotion (2)
Current base:
staging-promote/95dcf807-24717849306Current head:
staging-promote/edbf0eaa-24719068222Current range:
origin/staging-promote/95dcf807-24717849306..origin/staging-promote/edbf0eaa-24719068222Auto-updated by staging promotion metadata workflow
Waiting for gates:
Auto-created by staging-ci workflow