Skip to content

chore: promote staging to staging-promote/983a95cc-25026469392 (2026-04-28 06:43 UTC)#3008

Merged
henrypark133 merged 1 commit into
mainfrom
staging-promote/93d03055-25038069080
Apr 29, 2026
Merged

chore: promote staging to staging-promote/983a95cc-25026469392 (2026-04-28 06:43 UTC)#3008
henrypark133 merged 1 commit into
mainfrom
staging-promote/93d03055-25038069080

Conversation

@ironclaw-ci
Copy link
Copy Markdown
Contributor

@ironclaw-ci ironclaw-ci Bot commented Apr 28, 2026

Auto-promotion from staging CI

Batch range: 7fb41555a9e55677d1aaea29ca567a5b369c2b05..93d0305547837510d7f8d341429e03cda2a1e91d
Promotion branch: staging-promote/93d03055-25038069080
Base: staging-promote/983a95cc-25026469392
Triggered by: Staging CI batch at 2026-04-28 06:43 UTC

Commits in this batch (102):

Current commits in this promotion (1)

Current base: staging-promote/983a95cc-25026469392
Current head: staging-promote/93d03055-25038069080
Current range: origin/staging-promote/983a95cc-25026469392..origin/staging-promote/93d03055-25038069080

Auto-updated by staging promotion metadata workflow

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

@github-actions github-actions Bot added size: XS < 10 changed lines (excluding docs) risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Apr 28, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Apr 28, 2026

Code review

No issues found.

Summary:
The changes in this PR intentionally drop SSE plan_update and approval_needed events that lack a thread_id, which is correct per the architectural requirement that "Gate UI must remain thread-scoped" (documented in src/channels/web/CLAUDE.md). Events without thread context cannot be properly scoped to UI elements and were causing state drift.

Changes reviewed:

  • Removal of hasThread and forCurrentThread variables in the approval_needed handler (lines 393-406)
  • Change from if (forCurrentThread) to if (isCurrentThread(data.thread_id)) with an added guard else if (data.thread_id)
  • Simplification of the plan_update handler logic (line 546)

All changes align with documented architectural patterns and enforce thread-scoped event filtering correctly. System-level approvals (e.g., in settings) are still handled through separate code paths (line 409: refreshCurrentSettingsTab()), so no functionality is lost.

🤖 Generated with Claude Code

Base automatically changed from staging-promote/983a95cc-25026469392 to main April 29, 2026 04:09
@henrypark133 henrypark133 merged commit 93d0305 into main Apr 29, 2026
59 of 66 checks passed
@henrypark133 henrypark133 deleted the staging-promote/93d03055-25038069080 branch April 29, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules size: XS < 10 changed lines (excluding docs) staging-promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants