ktlint plugin switch

[AlvaroBrey]

• build: Replace ktlint plugin with spotless
• Fix pre-commit hook to use spotless
• Fix git hooks copy logic
• Update check workflow to use spotless
• Auto-fix ktlint format issues

Fixes #929

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	41
Total	151

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	17
Correctness Warnings	36
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	13
Security Warnings	1
Dodgy code Warnings	45
Total	164

[codecov]

Codecov Report

Merging #932 (5381d08) into master (72ca650) will decrease coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
- Coverage   48.75%   48.73%   -0.02%     
==========================================
  Files         171      171              
  Lines        6609     6611       +2     
  Branches      881      881              
==========================================
  Hits         3222     3222              
- Misses       2919     2921       +2     
  Partials      468      468              

Impacted Files	Coverage Δ
...b/resources/files/ToggleFileLockRemoteOperation.kt	55.55% <ø> (ø)
...b/resources/profile/GetHoverCardRemoteOperation.kt	62.50% <0.00%> (-2.72%)	⬇️
...es/search/UnifiedSearchProvidersRemoteOperation.kt	48.14% <0.00%> (-1.86%)	⬇️
...ary/src/main/java/com/nextcloud/common/DNSCache.kt	80.95% <ø> (ø)
...ain/java/com/owncloud/android/lib/common/Editor.kt	42.85% <0.00%> (ø)
...n/java/com/owncloud/android/lib/common/Template.kt	33.33% <0.00%> (ø)
...n/java/com/owncloud/android/lib/common/UserInfo.kt	57.14% <0.00%> (ø)
.../main/java/com/nextcloud/common/NextcloudClient.kt	57.14% <100.00%> (ø)
...va/com/owncloud/android/lib/common/ExternalLink.kt	100.00% <100.00%> (ø)
...main/java/com/owncloud/android/lib/common/Quota.kt	88.88% <100.00%> (ø)
... and 1 more

[AlvaroBrey]

Note to self: try Spotless instead. Seems to be widely used and may not need gradle 7.3

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	39
Total	149

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	17
Correctness Warnings	36
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	13
Security Warnings	1
Dodgy code Warnings	45
Total	164

[AlvaroBrey]

Spotless also can handle formatting for Markdown, Java, Groovy, XML, etc. We can later think about moving this to android-config and using it in all repos instead of individual formatting configurations

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	39
Total	149

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	17
Correctness Warnings	36
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	13
Security Warnings	1
Dodgy code Warnings	45
Total	164

[tobiasKaminsky]

@AlvaroBrey do you have an idea why codecov is so low? 36% compared to 48%?

[AlvaroBrey]

@AlvaroBrey do you have an idea why codecov is so low? 36% compared to 48%?

Coverage is still 48.73% (https://app.codecov.io/gh/nextcloud/android-library/compare/932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr%20comments&utm_term=nextcloud)

36% is the coverage of the diff i.e. only the changes in this PR. Looks like we have it configured to fail if the diff coverage is lower than the project coverage, which makes sense.