Use Spotless for ktlint

[AlvaroBrey]

Port of nextcloud/android-library#932

The old plugin does not check all sourcesets, and is unmaintained.

• Replace ktlint plugin with Spotless
• Update pre-commit hook to use spotless for kotlin
• Move installGitHooks task to root project and fix target dir
• Update check workflow to use spotless for kotlin
• build: Fix ktlint call in check task
• Fix previously undetected ktlint issues
• Suppress detekt issue brought up by reformatting:

• Tests written, or not not needed

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	85	85
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	29	29
Correctness	46	46
Dodgy code	354	354
Experimental	1	1
Internationalization	9	9
Multithreaded correctness	9	9
Performance	58	58
Security	28	28
Total	534	534

[codecov]

Codecov Report

Merging #10784 (b463c04) into master (0cd828b) will increase coverage by 0.01%.
The diff coverage is 13.46%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #10784      +/-   ##
============================================
+ Coverage     31.60%   31.62%   +0.01%     
- Complexity     3300     3301       +1     
============================================
  Files           539      539              
  Lines         40237    40264      +27     
  Branches       5555     5555              
============================================
+ Hits          12717    12733      +16     
- Misses        25617    25628      +11     
  Partials       1903     1903              

Impacted Files	Coverage Δ
...c/main/java/com/nextcloud/client/di/ThemeModule.kt	100.00% <ø> (ø)
...nextcloud/client/errorhandling/ExceptionHandler.kt	0.00% <ø> (ø)
...a/com/nextcloud/client/files/downloader/Request.kt	74.19% <ø> (ø)
.../com/nextcloud/client/jobs/BackgroundJobFactory.kt	63.63% <ø> (ø)
.../nextcloud/client/jobs/BackgroundJobManagerImpl.kt	61.63% <ø> (ø)
...va/com/nextcloud/client/jobs/CalendarBackupWork.kt	0.00% <ø> (ø)
...ava/com/nextcloud/client/logger/ui/LogsActivity.kt	0.00% <ø> (ø)
...xtcloud/client/migrations/MigrationsManagerImpl.kt	77.27% <ø> (ø)
.../nextcloud/utils/view/FastScrollPopupBackground.kt	29.68% <0.00%> (-2.52%)	⬇️
...wncloud/android/datamodel/ContentResolverHelper.kt	37.20% <ø> (ø)
... and 30 more

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10784.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[tobiasKaminsky]

Very cool!