Skip to content

Enhanced attachments support#2235

Open
mejo- wants to merge 15 commits intomainfrom
feat/folder_attachments
Open

Enhanced attachments support#2235
mejo- wants to merge 15 commits intomainfrom
feat/folder_attachments

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Feb 4, 2026 •
edited
Loading

📝 Summary

This PR enhances the attachment sidebar tab.

  • Upload/rename/delete attachments
  • Upload attachments via drag & drop into sidebar
  • Insert attachments into page content via drag & drop
  • List files that live in the folder directory as "Files next to page"
  • Resolves: Enhanced file management in collectives #1773

Requires nextcloud/text#8238 and nextcloud-libraries/nextcloud-vue#8169 (released).

🖼️ Screenshots

Attachments sidebar With drop area (on dragover) Attachment actions Rename modal
image image image image
Extra files actions Extra files info box
image image

🚧 TODO

  • Highlight attachments that are embedded in content.
  • Allow to undo deleting an attachment.
  • Add link to attachments folder in files?
  • Behat tests
  • Cypress tests

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@mejo- mejo- self-assigned this Feb 4, 2026
@mejo- mejo- requested a review from marcoambrosini February 5, 2026 08:26
@mejo- mejo- force-pushed the feat/folder_attachments branch from 58f62db to 1ef1512 Compare February 5, 2026 09:38
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Feb 5, 2026

Thanks a lot for tackling this! Looks great already.

Just based on the screenshots I have a few remarks.

Drop zone

I'd say always indicate the possibility to drag files in, even though less prominent. Maybe just [+ Upload] or drag files here.

Files next to page

If I have a Protocols page and a Today subpage that is a plain Today.md file... would the files in the Protocols folder also show in the Today subpage? I assume not - but the wording sounds like they do.

How about we rename the tab to Files and list all files there without separation. Files that have been attached to the page get an extra button next to the three dot menu that shows them in the page. This button could be a pin or an attachment symbol.
We could still sort the attached files to the top. But maybe it's even nicer to have a newly uploaded file on the top so it's easy to find.

mejo- added 12 commits February 5, 2026 12:17
@mejo-
feat(attachments): List folder attachments in sidebar tab
872fd15 
Allows to open, download and delete attachment files from page folder.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
feat(attachments): Allow to rename folder attachments in sidebar tab
40f276a 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
feat(attachments): rename and delete text attachments
405f81c 
We still list folder attachments, but don't allow to modify them.

We don't want to hide folder attachments as users might have added
them e.g. via local file sync, but we don't want to emphasize their
usage either.

Also fixes filename encoding when restoring deleted attachments with
special characters.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
feat(attachments): allow to upload new attachments in sidebar
c7152db 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
feat(attachments): add explanation button for "files next to page"
69455a4 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(PageInfoBar): reactive properties
e35b6b7 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(attachments): support dragging attachment into page
e239ff0 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
tmp upload attachment
3e18766
@mejo-
test(behat): add integration tests for attachments endpoints
faa12de 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
test(cypress): add cypress tests for attachments sidebar tab
acb2532 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
chore(attachments): move attachment item to its own component
5d93421 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(attachments): remove leftovers of "folder attachment" wording
d2d31c7 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/folder_attachments branch from 1ef1512 to c4d024a Compare February 6, 2026 10:12
mejo- added 3 commits February 6, 2026 16:19
@mejo-
feat(attachments): distinguish between embedded and not embedded
6aa0b88 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(AttachmentItem): Display rename option only with edit permissions
63046a3 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(AttachmentItem): show actions menu on hover/focus on desktop
561c135 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/folder_attachments branch from c4d024a to 561c135 Compare February 6, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

@silverkszlo silverkszlo Awaiting requested review from silverkszlo silverkszlo is a code owner

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

At least 1 approving review is required to merge this pull request.

Assignees

@mejo- mejo-

Labels

2. developing enhancement New feature or request feature: attachments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhanced file management in collectives

2 participants

@mejo- @max-nextcloud