Skip to content

feat: improve attachments integration with Collectives#8238

Open
mejo- wants to merge 5 commits intomainfrom
feat/collectives_attachments
Open

feat: improve attachments integration with Collectives#8238
mejo- wants to merge 5 commits intomainfrom
feat/collectives_attachments

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Feb 6, 2026

📝 Summary

  • feat(editorApi): Add functions for renaming and deleting attachments
  • feat(AttachmentService): Don't cleanup attachments for Collectives pages
  • feat(attachments): allow to listen for changes via editorApi

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

mejo- added 3 commits February 6, 2026 13:51
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Required by Collectives for attachment operations in sidebar.

Signed-off-by: Jonas <jonas@freesources.org>
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/plugins/extractAttachmentSrcs.ts 88.88% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mejo- mejo- force-pushed the feat/collectives_attachments branch from d8bb937 to c182d74 Compare February 6, 2026 14:54
@mejo-
Copy link
Member Author

mejo- commented Feb 6, 2026

/backport to stable33

mejo- added 2 commits February 6, 2026 15:57
Required for Collectives to track attachments.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/collectives_attachments branch from c182d74 to aa67811 Compare February 6, 2026 14:57
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the code without testing. Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants