Use the new Symfony event dispatcher signature#17084
Conversation
Signed-off-by: Christoph Wurst <[email protected]>
| Event $event): void { | ||
|
|
||
| $this->dispatcher->dispatch($eventName, $event); | ||
| $this->dispatcher->dispatch($event, $eventName); |
There was a problem hiding this comment.
While fine... I do like the new approach of the eventdispatcher to have the eventname default to the class.
There was a problem hiding this comment.
Not sure if that is the case. In their (updated) docs they always have a NAME constant added to subclasses. They might read that
|
This spams my log quite heavily. Should we adjust all existing events as well? |
|
If we have to touch it anyway we should move to the new OCP stuff I'd say |
|
Yes, we should migrate to our own dispatcher ASAP. The log spam is only partly this PR's fault. There is a lot of magic going on in the Symfony adapter since 4.4 where they deprecate their old API. |
Leftover from the 4.3 bump at #17049.
Fixes the
deprecation for the new event dispatcher.