Conversation
Member
Author
|
This now includes the changes from #17084 as |
Member
|
Which methods are affected? |
Member
Author
|
Do they use Symfony directly or our abstraction? |
Member
|
Both functions are still there. |
Member
Also note that it is only for things that use the new event stuff. So talk is not affected right now. |
blizzz
approved these changes
Sep 11, 2019
Member
Author
|
Pushed another commit. 🤞 this makes our tests happy. Apparently we ran into a form of the fragile base class problem. Yay. |
ChristophWurst
commented
Sep 11, 2019
blizzz
approved these changes
Sep 12, 2019
rullzer
approved these changes
Sep 12, 2019
Member
|
rebase |
Signed-off-by: Christoph Wurst <[email protected]>
e982b4d to
a1ef939
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from the 4.3 bump at #17049.
Fixes the
deprecation for the new event dispatcher system. In theory this could be a breaking change as apps might have used methods of the old base class, but the likelihood is very low IMO.