tests: test the tests fail when expected#2097
Merged
mergify[bot] merged 1 commit intonix-community:mainfrom Aug 27, 2024
Merged
tests: test the tests fail when expected#2097mergify[bot] merged 1 commit intonix-community:mainfrom
mergify[bot] merged 1 commit intonix-community:mainfrom
Conversation
Adds a regression test for nix-community#2076. This test ensures that `extraConfigLua` is used in `finalPackage` and that the test will fail correctly when running `nvim` results in unexpected output.
MattSturgeon
changed the title
khaneliman
approved these changes
Aug 27, 2024
Contributor
khaneliman
left a comment
khaneliman
left a comment
There was a problem hiding this comment.
LGTM. I see the failure being reported in a nix flake check when I undo the previous fix. I see it succeed nix flake check with the current state.
traxys
approved these changes
Aug 27, 2024
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 60ea38d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for #2076. This test ensures that
extraConfigLuais used infinalPackageand that the test will fail correctly when runningnvimresults in unexpected output.I was hoping to also test more explicitly that an eval failure would be triggered when
extraConfigLuais set to something invalid, but verifying the"Hello, world!"string makes it into the build log should cover most of those cases too.At the very least this regression test ensures:
extraConfigLuais used in theinit.luaused to runnvimin the testtest.runNvimcorrectly fails when neovim prints unexpected stdoutI used
pkgs.testers.testBuildFailureas a helper, to aid in expecting a derivation build to fail.