tests: add regression test for warnings + assertions#2100
Merged
mergify[bot] merged 1 commit intonix-community:mainfrom Aug 28, 2024
Merged
tests: add regression test for warnings + assertions#2100mergify[bot] merged 1 commit intonix-community:mainfrom
mergify[bot] merged 1 commit intonix-community:mainfrom
Conversation
Ensure `mkTestDerivationFromNixvimModule` correctly test warnings & assertions. Also did some minor cleanup: - Call `failing-tests.nix` using `pkgs.callPackage` - Replace repetive use of `testBuildFailure` with a wrapper `mkFailingNixvimTest`
khaneliman
approved these changes
Aug 28, 2024
Contributor
khaneliman
left a comment
khaneliman
left a comment
There was a problem hiding this comment.
LGTM, this is giving me ideas about negative test cases...
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
I think most negative tests can be achieved by setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2097, #2076, & #2048.
Expand "failing-tests" to also ensure warnings & assertions are correctly handled by
mkTestDerivationFromNixvimModule.Also did some minor cleanup:
failing-tests.nixusingpkgs.callPackagetestBuildFailurewith a wrappermkFailingNixvimTestYou can run just the "failing" tests by using:
You can also use the
entriespassthu to access a specific sub-test:nix build .#checks.x86_64-linux.failing-tests.entries.fail-on-assertions(tab-completion can help here)
See also,
linkFarmFromDrvs