tests: simplify fetch-tests slightly#2101
Merged
mergify[bot] merged 1 commit intonix-community:mainfrom Aug 28, 2024
Merged
Conversation
khaneliman
approved these changes
Aug 28, 2024
Simplify by reducing the number of transformations done to the test-files' test-case modules attr. Since `pkgs.linkFarm` can accept _either_ a list or an attrset, we don't need to transform the attrset into a list.
MattSturgeon
force-pushed
the
test_linkfarm_cleanup
branch
from
62f330c to
975af6a
Compare
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 975af6a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify by reducing the number of transformations done to the test-files' test-case modules attr.
Since
pkgs.linkFarmcan accept either a list or an attrset, we don't need to transform the attrset into a list.This has no functional change, and only slightly simplifies some internals. It may end up being redundant if we re-structure the tests again, but I spotted the slight over-complication while working on #2100 so figured I'd make a PR.