Skip to content

treewide: deprecate manual targets.${target}.useWallpaper.enable options#2084

Merged
trueNAHO merged 1 commit intonix-community:masterfrom
trueNAHO:treewide-deprecate-manual-targets-target-use-wallpaper-enable-options
Feb 1, 2026
Merged

treewide: deprecate manual targets.${target}.useWallpaper.enable options#2084
trueNAHO merged 1 commit intonix-community:masterfrom
trueNAHO:treewide-deprecate-manual-targets-target-use-wallpaper-enable-options

Conversation

@trueNAHO
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO commented Dec 10, 2025

Deprecate manual targets.${target}.useWallpaper.enable options with
generated targets.${target}.image.enable options, following commit
953c3fb01e2a ("stylix/mk-target: generate options for configuring
safeguarded arguments").

The following remaining useWallpaper instances cannot yet be deprecated because their modules have not yet migrated to mkTarget:

$ rg --files-with-matches 'useWallpaper ='
modules/grub/nixos.nix
modules/kde/hm.nix
modules/sway/hm.nix

I have not tested this code and merely assume this works as expected. This has been tested in #2084 (review).


@trueNAHO trueNAHO added the backport: release-25.11 To be backported to the release-25.11 stable branch label Dec 10, 2025
@stylix-automation stylix-automation bot added topic: nixos NixOS target topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Dec 10, 2025
@trueNAHO trueNAHO mentioned this pull request Dec 10, 2025
6 tasks
@trueNAHO trueNAHO force-pushed the treewide-deprecate-manual-targets-target-use-wallpaper-enable-options branch 2 times, most recently from 47e1eb9 to 0a2ffb6 Compare December 10, 2025 23:10
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Copy link
Copy Markdown
Member Author

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this code and merely assume this works as expected.

The following tests successfully build:

  • diff --git a/modules/regreet/testbeds/regreet.nix b/modules/regreet/testbeds/regreet.nix
    index a4ec92ae..618b32fc 100644
    --- a/modules/regreet/testbeds/regreet.nix
    +++ b/modules/regreet/testbeds/regreet.nix
    @@ -1 +1,4 @@
    -{ programs.regreet.enable = true; }
    +{
    +  stylix.targets.regreet.useWallpaper = true;
    +  programs.regreet.enable = true;
    +}
  • diff --git a/modules/regreet/testbeds/regreet.nix b/modules/regreet/testbeds/regreet.nix
    index a4ec92ae..388498ee 100644
    --- a/modules/regreet/testbeds/regreet.nix
    +++ b/modules/regreet/testbeds/regreet.nix
    @@ -1 +1,4 @@
    -{ programs.regreet.enable = true; }
    +{
    +  stylix.targets.regreet.useWallpaper = false;
    +  programs.regreet.enable = true;
    +}

@trueNAHO trueNAHO requested a review from 0xda157 January 11, 2026 13:49
@stylix-automation stylix-automation bot added the status: merge conflict Merge conflict label Jan 14, 2026
Deprecate manual targets.${target}.useWallpaper.enable options with
generated targets.${target}.image.enable options, following commit
953c3fb ("stylix/mk-target: generate options for configuring
safeguarded arguments").
@trueNAHO trueNAHO force-pushed the treewide-deprecate-manual-targets-target-use-wallpaper-enable-options branch from 0a2ffb6 to f42c40c Compare January 31, 2026 20:29
@trueNAHO trueNAHO removed the backport: release-25.11 To be backported to the release-25.11 stable branch label Feb 1, 2026
@trueNAHO trueNAHO merged commit ce22070 into nix-community:master Feb 1, 2026
4 checks passed
Pascal0577 added a commit to Pascal0577/stylix that referenced this pull request Feb 4, 2026
dastarruer pushed a commit to dastarruer/stylix that referenced this pull request Feb 13, 2026
…ons (nix-community#2084)

Deprecate manual targets.${target}.useWallpaper.enable options with
generated targets.${target}.image.enable options, following commit
953c3fb ("stylix/mk-target: generate options for configuring
safeguarded arguments").

Link: nix-community#2084

Reviewed-by: 0xda157 <da157@voidq.com>
@trueNAHO trueNAHO mentioned this pull request Feb 14, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: merge conflict Merge conflict topic: home-manager Home Manager target topic: modules /modules/ subsystem topic: nixos NixOS target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants