treewide: deprecate manual targets.${target}.useWallpaper.enable options#2084
Merged
trueNAHO merged 1 commit intonix-community:masterfrom Feb 1, 2026
Conversation
trueNAHO
commented
Dec 10, 2025
47e1eb9 to
0a2ffb6
Compare
trueNAHO
commented
Jan 5, 2026
Member
Author
trueNAHO
left a comment
There was a problem hiding this comment.
I have not tested this code and merely assume this works as expected.
The following tests successfully build:
-
diff --git a/modules/regreet/testbeds/regreet.nix b/modules/regreet/testbeds/regreet.nix index a4ec92ae..618b32fc 100644 --- a/modules/regreet/testbeds/regreet.nix +++ b/modules/regreet/testbeds/regreet.nix @@ -1 +1,4 @@ -{ programs.regreet.enable = true; } +{ + stylix.targets.regreet.useWallpaper = true; + programs.regreet.enable = true; +}
-
diff --git a/modules/regreet/testbeds/regreet.nix b/modules/regreet/testbeds/regreet.nix index a4ec92ae..388498ee 100644 --- a/modules/regreet/testbeds/regreet.nix +++ b/modules/regreet/testbeds/regreet.nix @@ -1 +1,4 @@ -{ programs.regreet.enable = true; } +{ + stylix.targets.regreet.useWallpaper = false; + programs.regreet.enable = true; +}
0xda157
approved these changes
Jan 31, 2026
Deprecate manual targets.${target}.useWallpaper.enable options with
generated targets.${target}.image.enable options, following commit
953c3fb ("stylix/mk-target: generate options for configuring
safeguarded arguments").
0a2ffb6 to
f42c40c
Compare
Pascal0577
added a commit
to Pascal0577/stylix
that referenced
this pull request
Feb 4, 2026
…ble options (nix-community#2084)" This reverts commit ce22070.
dastarruer
pushed a commit
to dastarruer/stylix
that referenced
this pull request
Feb 13, 2026
…ons (nix-community#2084) Deprecate manual targets.${target}.useWallpaper.enable options with generated targets.${target}.image.enable options, following commit 953c3fb ("stylix/mk-target: generate options for configuring safeguarded arguments"). Link: nix-community#2084 Reviewed-by: 0xda157 <da157@voidq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following remaining
useWallpaperinstances cannot yet be deprecated because their modules have not yet migrated tomkTarget:I have not tested this code and merely assume this works as expected.This has been tested in #2084 (review).