Skip to content

[Fix]: Fix NodeJS download link for armv8l #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljharb merged 1 commit into from
May 6, 2023
Merged

[Fix]: Fix NodeJS download link for armv8l #3102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1913,7 +1913,7 @@ nvm_get_arch() {
case "${HOST_ARCH}" in
x86_64 | amd64) NVM_ARCH="x64" ;;
i*86) NVM_ARCH="x86" ;;
aarch64) NVM_ARCH="arm64" ;;
aarch64 | armv8l) NVM_ARCH="arm64" ;;
*) NVM_ARCH="${HOST_ARCH}" ;;
esac

Expand Down
1 change: 1 addition & 0 deletions test/fast/Unit tests/nvm_get_arch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,6 @@ run_test x86 osx x86
run_test amd64 osx x64

run_test arm64 smartos x64
run_test armv8l smartos x64

cleanup
5 changes: 5 additions & 0 deletions test/mocks/uname_linux_armv8l
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
if [ "_$1" = "_-m" ]; then
echo "armv8l"
else
echo "Linux 3.18.14-14721103 #1 SMP PREEMPT Thu Mar 5 20:35:37 KST 2020 armv8l armv8l armv8l GNU/Linux"
fi