Docker: Fix entrypoint to run as PID 1#731
Merged
phnzb merged 4 commits intonzbgetcom:developfrom Feb 6, 2026
Merged
Conversation
Collaborator
|
@calvinbui Thank you for the contribution. Tested on Ubuntu 24.04.3 LTS and Docker 28.3.3; no issues found. Merged into |
phnzb
approved these changes
Feb 6, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
su -p -cwithexec su-execwhen running as root, and addexecwhen running as non-root user.Without
exec, the shell script remains as PID 1 and nzbget runs as a child process. This means Docker's stop signal (SIGTERM) are sent to the shell, not nzbget, preventing graceful shutdown.SIGKILLis sent when theSIGTERMtimes out.Using
execreplaces the shell process with nzbget, making it PID 1.There are also small improvements in the Dockerfile:
sh--no-cacheargument forapkLib changes
N/A
Testing
I built and ran the image. When I restarted/stopped it and saw
[INFO] Stopping, please wait...in the logs.I performed the same test with
ghcr.io/nzbgetcom/nzbget:v26.0and the log message didn't appear.