Skip to content

Docker: Fix entrypoint to run as PID 1 #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phnzb merged 4 commits into from
Feb 6, 2026
Merged

Docker: Fix entrypoint to run as PID 1 #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
708db26
apk add --no-cache
calvinbui Feb 5, 2026
bb663d0
sh only supports = for equality comparison
calvinbui Feb 5, 2026
9cbcf39
use COPY instead of ADD
calvinbui Feb 5, 2026
8c97e1a
run nzbget as pid 1 using exec
calvinbui Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ARG CMAKE_BUILD_TYPE=Release
#install build packages
RUN \
echo "**** install build packages ****" && \
apk add g++ gcc git libxml2-dev libxslt-dev make ncurses-dev openssl-dev boost-dev curl cmake
apk add --no-cache g++ gcc git libxml2-dev libxslt-dev make ncurses-dev openssl-dev boost-dev curl cmake

#install archive packages
RUN \
Expand All @@ -22,11 +22,11 @@ RUN \
curl -o /tmp/unrar7.tar.gz -L "https://www.rarlab.com/rar/unrarsrc-${UNRAR7_VERSION}.tar.gz" && \
tar xf /tmp/unrar7.tar.gz -C /tmp/unrar7 --strip-components=1 && \
cd /tmp/unrar7 && \
if [ "${UNRAR7_NATIVE}" != "true" ] && [ "${TARGETPLATFORM}" == "linux/amd64" ]; \
if [ "${UNRAR7_NATIVE}" != "true" ] && [ "${TARGETPLATFORM}" = "linux/amd64" ]; \
then sed -i "s|CXXFLAGS=-march=native|CXXFLAGS=-march=x86-64-v2|" makefile; fi && \
if [ "${UNRAR7_NATIVE}" != "true" ] && [ "${TARGETPLATFORM}" == "linux/arm64" ]; \
if [ "${UNRAR7_NATIVE}" != "true" ] && [ "${TARGETPLATFORM}" = "linux/arm64" ]; \
then sed -i "s|CXXFLAGS=-march=native|CXXFLAGS=-march=armv8-a+crypto+crc|" makefile; fi && \
if [ "${UNRAR7_NATIVE}" != "true" ] && [ "${TARGETPLATFORM}" == "linux/arm/v7" ]; \
if [ "${UNRAR7_NATIVE}" != "true" ] && [ "${TARGETPLATFORM}" = "linux/arm/v7" ]; \
then sed -i "s|CXXFLAGS=-march=native|CXXFLAGS=-march=armv7-a|" makefile; fi && \
make -j ${MAKE_JOBS} && \
install -v -m755 unrar /usr/bin/unrar7 && \
Expand All @@ -47,7 +47,7 @@ RUN \
install -v -m755 _o/7za /usr/bin/7z

#build nzbget
ADD ./ nzbget
COPY ./ /nzbget
RUN \
echo "**** build nzbget ****" && \
mkdir -p /app/nzbget && \
Expand Down Expand Up @@ -98,13 +98,13 @@ COPY --from=build /usr/bin/7z /usr/bin/7z
COPY --from=build /app/nzbget/ /app/nzbget/
RUN \
echo "**** install packages ****" && \
apk add --no-cache --update shadow libxml2 libxslt openssl python3 boost1.84-json boost1.84-filesystem tzdata && \
apk add --no-cache --update shadow su-exec libxml2 libxslt openssl python3 boost1.84-json boost1.84-filesystem tzdata && \
ln -sf /usr/bin/python3 /usr/bin/python && \
ln -s /usr/bin/7z /app/nzbget/7za && \
ln -s /usr/bin/unrar /app/nzbget/unrar && \
echo "**** cleanup ****" && \
rm -rf /root/.cache /root/.cargo /tmp/*
ADD docker/entrypoint.sh /entrypoint.sh
COPY docker/entrypoint.sh /entrypoint.sh
RUN chmod +x /entrypoint.sh && \
echo "**** create non-root user ****" && \
adduser -G users -D -u 1000 -h /config -s /bin/sh user && \
Expand Down
4 changes: 2 additions & 2 deletions docker/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ if [ "$(id -u)" -eq 0 ]; then
echo "*** Could not set permissions on /downloads ; this container may not work as expected ***"
fi

su -p user -c "/app/nzbget/nzbget -s -c /config/nzbget.conf -o OutputMode=log ${OPTIONS}"
exec su-exec user:users /app/nzbget/nzbget -s -c /config/nzbget.conf -o OutputMode=log ${OPTIONS}
else
/app/nzbget/nzbget -s -c /config/nzbget.conf -o OutputMode=log ${OPTIONS}
exec /app/nzbget/nzbget -s -c /config/nzbget.conf -o OutputMode=log ${OPTIONS}
fi